. Romieu suggested I forward this to you...
Thanks,
Ben
Original Message
Subject:[PATCH 3/4] 8139too: RTNL and flush_scheduled_work deadlock
Date: Thu, 15 Feb 2007 23:37:44 +0100
From: Francois Romieu <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
CC: Stephen Hem
Ben Greear <[EMAIL PROTECTED]> :
[...]
> It looks like this has not made it into the 2.6.20 stable series
> patches... Any reason not to add it there?
No. Go ahead and submit it.
--
Ueimor
Anybody got a battery for my Ultra 10 ?
-
To unsubscribe from this list: send the line "unsubscribe netde
Francois Romieu wrote:
Your usual dont-flush_scheduled_work-with-RTNL-held stuff.
It is a bit different here since the thread runs permanently
or is only occasionally kicked for recovery depending on the
hardware revision.
It looks like this has not made it into the 2.6.20 stable series
patche
Cc: list trimmed.
Jarek Poplawski <[EMAIL PROTECTED]> :
> On Fri, Feb 16, 2007 at 09:20:34PM +0100, Francois Romieu wrote:
[...]
> > Btw, the thread runs every 3*HZ at most.
>
> You are right (mostly)! But I think rtnl_lock is special
> and should be spared (even this 3*HZ) and here it's used
> f
On Fri, Feb 16, 2007 at 09:20:34PM +0100, Francois Romieu wrote:
> Jarek Poplawski <[EMAIL PROTECTED]> :
...
> > > @@ -1603,18 +1605,21 @@ static void rtl8139_thread (struct work_struct
> > > *work)
> > > struct net_device *dev = tp->mii.dev;
> > > unsigned long thr_delay = next_tick;
> > >
Stephen Hemminger <[EMAIL PROTECTED]> :
[...]
> You need to hold a dev reference (dev_hold) as well. to keep the device
> from disappearing. or do a flush_scheduled_work in the remove routine.
The patched drivers do #2 (before unregister_netdev).
--
Ueimor
-
To unsubscribe from this list: send t
On Fri, 16 Feb 2007 21:20:34 +0100
Francois Romieu <[EMAIL PROTECTED]> wrote:
> Jarek Poplawski <[EMAIL PROTECTED]> :
> [...]
> > > diff --git a/drivers/net/8139too.c b/drivers/net/8139too.c
> > > index 35ad5cf..99304b2 100644
> > > --- a/drivers/net/8139too.c
> > > +++ b/drivers/net/8139too.c
> >
Jarek Poplawski <[EMAIL PROTECTED]> :
[...]
> > diff --git a/drivers/net/8139too.c b/drivers/net/8139too.c
> > index 35ad5cf..99304b2 100644
> > --- a/drivers/net/8139too.c
> > +++ b/drivers/net/8139too.c
> > @@ -1109,6 +1109,8 @@ static void __devexit rtl8139_remove_one (struct
> > pci_dev *pdev)
On 15-02-2007 23:37, Francois Romieu wrote:
> Your usual dont-flush_scheduled_work-with-RTNL-held stuff.
>
> It is a bit different here since the thread runs permanently
> or is only occasionally kicked for recovery depending on the
> hardware revision.
>
> Signed-off-by: Francois Romieu <[EMAIL
Your usual dont-flush_scheduled_work-with-RTNL-held stuff.
It is a bit different here since the thread runs permanently
or is only occasionally kicked for recovery depending on the
hardware revision.
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]>
---
drivers/net/8139too.c | 40
10 matches
Mail list logo
