Re: [PATCH 3/4] ethtool: can't set combined and tx/rx channel counts at the same time

2016-02-08 Thread Keller, Jacob E
On Mon, 2016-02-08 at 20:52 +, Jakub Kicinski wrote: > On Mon,  8 Feb 2016 12:06:04 -0800, Jacob Keller wrote: > > + /* can't set combined and separate channels at the same > > time */ > > + if ((channels.combined_count && > > +  (channels.rx_count || channels.tx_count)) > > + r

Re: [PATCH 3/4] ethtool: can't set combined and tx/rx channel counts at the same time

2016-02-08 Thread Keller, Jacob E
On Mon, 2016-02-08 at 20:52 +, Jakub Kicinski wrote: > On Mon,  8 Feb 2016 12:06:04 -0800, Jacob Keller wrote: > > + /* can't set combined and separate channels at the same > > time */ > > + if ((channels.combined_count && > > +  (channels.rx_count || channels.tx_count)) > > + r

Re: [PATCH 3/4] ethtool: can't set combined and tx/rx channel counts at the same time

2016-02-08 Thread Jakub Kicinski
On Mon, 8 Feb 2016 12:06:04 -0800, Jacob Keller wrote: > + /* can't set combined and separate channels at the same time */ > + if ((channels.combined_count && > + (channels.rx_count || channels.tx_count)) > + return -EINVAL; > + > /* ensure the new Rx count fits with

Re: [PATCH 3/4] ethtool: can't set combined and tx/rx channel counts at the same time

2016-02-08 Thread kbuild test robot
Hi Jacob, [auto build test WARNING on net/master] [also build test WARNING on v4.5-rc3 next-20160208] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Jacob-Keller/ethtool-correctly-ensure-GS-CH

Re: [PATCH 3/4] ethtool: can't set combined and tx/rx channel counts at the same time

2016-02-08 Thread kbuild test robot
Hi Jacob, [auto build test ERROR on net/master] [also build test ERROR on v4.5-rc3 next-20160208] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Jacob-Keller/ethtool-correctly-ensure-GS-CHANNE

[PATCH 3/4] ethtool: can't set combined and tx/rx channel counts at the same time

2016-02-08 Thread Jacob Keller
Based on reading current implementations of {GS}CHANNELS, most drivers either support only combined counts or only separate counts. At least one driver supported setting combined or separate channels. No driver supported combined and separate channels setting at the same time, and this patch adds a