> Here's a delusional reply: I didn't see any point to it.
> 1) a wmb would add overhead
> 2) the hardware is supposed to be looking at the status flag,
>anyway, and not misbehaving.
> 3) there is a wmb when the descr is actually refilled in such
>a way as to actually mean something to th
If you're going to be paranoid, shouldn't you do something here to
make
sure the value's hit the device?
I thought the whole point of paranoia is that its inexplicable.
Here's a delusional reply: I didn't see any point to it.
1) a wmb would add overhead
A wmb() doesn't guarantee the write ha
Invalidate a pointer as its pci_unmap'ed; this is a bit of
paranoia to make sure hardware doesn't continue trying to
DMA to it.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
Index: netdev-2.6/dri
On Thu, May 17, 2007 at 09:32:56AM +1000, Michael Ellerman wrote:
> > + hwdescr->buf_addr = 0x0;
>
> If you're going to be paranoid, shouldn't you do something here to make
> sure the value's hit the device?
I thought the whole point of paranoia is that its inexplicable.
Here's a delusional re
On Wed, 2007-05-16 at 17:09 -0500, Linas Vepstas wrote:
> Invalidate a pointer as its pci_unmap'ed; this is a bit of
> paranoia to make sure hardware doesn't continue trying to
> DMA to it.
>
> Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
>
>
> drivers/net/spider_net.c |7 +--
Invalidate a pointer as its pci_unmap'ed; this is a bit of
paranoia to make sure hardware doesn't continue trying to
DMA to it.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
Index: linux-2.6.22-r
