Re: [PATCH 4/4] forcedeth: fix multi irq issues

2006-04-05 Thread Manfred Spraul
Ayaz Abdulla wrote: Manfred Spraul wrote: Ayaz Abdulla wrote: if (nv_alloc_rx(dev)) { -spin_lock(np-lock); +spin_lock_irqsave(np-lock, flags); Tiny point: there is not need for irqsave(): we are in timer context, that guarantees: - bottom half disabled -

Re: [PATCH 4/4] forcedeth: fix multi irq issues

2006-04-05 Thread Manfred Spraul
Ayaz Abdulla wrote: This patch fixes the issues with multiple irqs. I am resending based on feedback. I decoupled the dma mask for consistent memory and fixed leak with multiple irq in error path. Thanks to Manfred for catching the spin lock problem. Signed-Off-By: Ayaz Abdulla [EMAIL

[PATCH 4/4] forcedeth: fix multi irq issues

2006-04-04 Thread Ayaz Abdulla
This patch fixes the issues with multiple irqs. I am resending based on feedback. I decoupled the dma mask for consistent memory and fixed leak with multiple irq in error path. Thanks to Manfred for catching the spin lock problem. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED]

Re: [PATCH 4/4] forcedeth: fix multi irq issues

2006-04-01 Thread Ayaz Abdulla
Manfred Spraul wrote: Ayaz Abdulla wrote: if (nv_alloc_rx(dev)) { -spin_lock(np-lock); +spin_lock_irqsave(np-lock, flags); Tiny point: there is not need for irqsave(): we are in timer context, that guarantees: - bottom half disabled - interrupts enabled Just use

Re: [PATCH 4/4] forcedeth: fix multi irq issues

2006-03-31 Thread Manfred Spraul
Ayaz Abdulla wrote: if (nv_alloc_rx(dev)) { - spin_lock(np-lock); + spin_lock_irqsave(np-lock, flags); Tiny point: there is not need for irqsave(): we are in timer context, that guarantees: - bottom half disabled - interrupts enabled Just use

[PATCH 4/4] forcedeth: fix multi irq issues

2006-03-30 Thread Ayaz Abdulla
This patch fixes the issues with multiple irqs. Thanks to Manfred for catching the spin lock problem. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- This email message is for the sole use of the intended