Re: [PATCH 4/4] net: dsa: Add Lantiq / Intel DSA driver for vrx200

2018-07-29 Thread Andrew Lunn
> >> +static const struct gswip_rmon_cnt_desc gswip_rmon_cnt[] = { > >> + /** Receive Packet Count (only packets that are accepted and not > >> discarded). */ > >> + MIB_DESC(1, 0x1F, "RxGoodPkts"), > >> + /** Receive Size 1024-1522 (or more, if configured) Packet Count. */ > >> + MIB_DESC(1,

Re: [PATCH 4/4] net: dsa: Add Lantiq / Intel DSA driver for vrx200

2018-07-29 Thread Hauke Mehrtens
On 07/25/2018 06:12 PM, Andrew Lunn wrote: >> LANTIQ MIPS ARCHITECTURE >> M: John Crispin >> diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig >> index 2b81b97e994f..f1280aa3f9bd 100644 >> --- a/drivers/net/dsa/Kconfig >> +++ b/drivers/net/dsa/Kconfig >> @@ -23,6 +23,14 @@ config N

Re: [PATCH 4/4] net: dsa: Add Lantiq / Intel DSA driver for vrx200

2018-07-25 Thread Andrew Lunn
> > i extracted this struct/blob/voodoo from UGW3/4 7 years ago and was puzzled > by it. for those of us that have worked with this table in the past, its > semi understandable, yet its almost like a blackbox FW blob. can we try to > make it a little more readable by adding a comment on each line

Re: [PATCH 4/4] net: dsa: Add Lantiq / Intel DSA driver for vrx200

2018-07-25 Thread John Crispin
On 21/07/18 21:13, Hauke Mehrtens wrote: +#define MC_ENTRY(val, msk, ns, out, len, type, flags, ipv4_len) \ + { val, msk, (ns << 10 | out << 4 | len >> 1),\ + (len & 1) << 15 | type << 13 | flags << 9 | ipv4_len << 8 } +static const struct gswip_pce_microcode gswip_pce_micr

Re: [PATCH 4/4] net: dsa: Add Lantiq / Intel DSA driver for vrx200

2018-07-25 Thread Andrew Lunn
> LANTIQ MIPS ARCHITECTURE > M: John Crispin > diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig > index 2b81b97e994f..f1280aa3f9bd 100644 > --- a/drivers/net/dsa/Kconfig > +++ b/drivers/net/dsa/Kconfig > @@ -23,6 +23,14 @@ config NET_DSA_LOOP > This enables support for a

Re: [PATCH 4/4] net: dsa: Add Lantiq / Intel DSA driver for vrx200

2018-07-22 Thread Hauke Mehrtens
On 07/22/2018 05:17 AM, David Miller wrote: > From: Hauke Mehrtens > Date: Sat, 21 Jul 2018 21:13:58 +0200 > >> +// start the table access: > > Please stick to C-style comments, except perhaps in the SPDX > identifiers. > > Thank you. > Sorry that I missed that, it is fixed now.

Re: [PATCH 4/4] net: dsa: Add Lantiq / Intel DSA driver for vrx200

2018-07-21 Thread David Miller
From: Hauke Mehrtens Date: Sat, 21 Jul 2018 21:13:58 +0200 > + // start the table access: Please stick to C-style comments, except perhaps in the SPDX identifiers. Thank you.

[PATCH 4/4] net: dsa: Add Lantiq / Intel DSA driver for vrx200

2018-07-21 Thread Hauke Mehrtens
This adds the DSA driver for the GSWIP Switch found in the VRX200 SoC. This switch is integrated in the DSL SoC, this SoC uses a GSWIP version 2.0, there are other SoCs using different versions of this IP block, but this driver was only tested with the version found in the VRX200. Currently only th