[PATCH 5/6] can: flexcan: add CAN wakeup function for i.MX8QM

2020-10-15 Thread Joakim Zhang
The System Controller Firmware (SCFW) is a low-level system function which runs on a dedicated Cortex-M core to provide power, clock, and resource management. It exists on some i.MX8 processors. e.g. i.MX8QM (QM, QP), and i.MX8QX (QXP, DX). SCU driver manages the IPC interface between host CPU and

Re: [PATCH 5/6] can: flexcan: add CAN wakeup function for i.MX8QM

2020-10-15 Thread Marc Kleine-Budde
On 10/16/20 3:43 PM, Joakim Zhang wrote: > The System Controller Firmware (SCFW) is a low-level system function > which runs on a dedicated Cortex-M core to provide power, clock, and > resource management. It exists on some i.MX8 processors. e.g. i.MX8QM > (QM, QP), and i.MX8QX (QXP, DX). SCU drive

Re: [PATCH 5/6] can: flexcan: add CAN wakeup function for i.MX8QM

2020-10-15 Thread Marc Kleine-Budde
On 10/16/20 3:43 PM, Joakim Zhang wrote: > The System Controller Firmware (SCFW) is a low-level system function > which runs on a dedicated Cortex-M core to provide power, clock, and > resource management. It exists on some i.MX8 processors. e.g. i.MX8QM > (QM, QP), and i.MX8QX (QXP, DX). SCU drive

RE: [PATCH 5/6] can: flexcan: add CAN wakeup function for i.MX8QM

2020-10-15 Thread Joakim Zhang
ernel.org; Pankaj Bansal ; > netdev@vger.kernel.org; devicet...@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: Re: [PATCH 5/6] can: flexcan: add CAN wakeup function for i.MX8QM > > On 10/16/20 3:43 PM, Joakim Zhang wrote: > > The System Controller Firmware (SCFW) is a

RE: [PATCH 5/6] can: flexcan: add CAN wakeup function for i.MX8QM

2020-10-15 Thread Joakim Zhang
ernel.org; Pankaj Bansal ; > netdev@vger.kernel.org; devicet...@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: Re: [PATCH 5/6] can: flexcan: add CAN wakeup function for i.MX8QM > > On 10/16/20 3:43 PM, Joakim Zhang wrote: > > The System Controller Firmware (SCFW) is a

Re: [PATCH 5/6] can: flexcan: add CAN wakeup function for i.MX8QM

2020-10-16 Thread Marc Kleine-Budde
On 10/16/20 8:46 AM, Joakim Zhang wrote: >>> @@ -2019,6 +2109,7 @@ static int flexcan_probe(struct platform_device >> *pdev) >>> priv->clk_src = clk_src; >>> priv->devtype_data = devtype_data; >>> priv->reg_xceiver = reg_xceiver; >>> + priv->can_idx = can_idx; >>> >>> if (priv->de

RE: [PATCH 5/6] can: flexcan: add CAN wakeup function for i.MX8QM

2020-10-16 Thread Joakim Zhang
Hi Marc, [...] > > > +static int flexcan_stop_mode_enable_scfw(struct flexcan_priv *priv, > > > +bool enabled) { > > > + u8 idx = priv->can_idx; > > > + u32 rsrc_id, val; > > > + > > > + if (idx == 0) > > > + rsrc_id = IMX_SC_R_CAN_0; > > > + else if (idx == 1) > > > + rsrc_id = I

Re: [PATCH 5/6] can: flexcan: add CAN wakeup function for i.MX8QM

2020-10-16 Thread Marc Kleine-Budde
On 10/16/20 12:00 PM, Joakim Zhang wrote: +static int flexcan_stop_mode_enable_scfw(struct flexcan_priv *priv, +bool enabled) { + u8 idx = priv->can_idx; + u32 rsrc_id, val; + + if (idx == 0) + rsrc_id = IMX_SC_R_CAN_0; + else if (idx == 1)

RE: [PATCH 5/6] can: flexcan: add CAN wakeup function for i.MX8QM

2020-10-16 Thread Joakim Zhang
ernel.org; Pankaj Bansal ; > netdev@vger.kernel.org; devicet...@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: Re: [PATCH 5/6] can: flexcan: add CAN wakeup function for i.MX8QM > > On 10/16/20 12:00 PM, Joakim Zhang wrote: > >>>> +static int flexcan_stop_mode_enabl