Re: [PATCH 6/10] ixgbe: Use ARRAY_SIZE macro

2017-09-06 Thread Joe Perches
On Wed, 2017-09-06 at 11:08 +0200, Thomas Meyer wrote: > On Tue, Sep 05, 2017 at 02:22:05PM -0700, David Miller wrote: > > nothing prevented you from CC:'ing the maintainer, > > Jeff Kirscher. [] > That's the other condition in my script. I only send to the role > "maintainer" from the output of ge

Re: [PATCH 6/10] ixgbe: Use ARRAY_SIZE macro

2017-09-06 Thread Thomas Meyer
On Tue, Sep 05, 2017 at 02:22:05PM -0700, David Miller wrote: > From: Joe Perches > Date: Tue, 05 Sep 2017 13:01:18 -0700 > > > On Tue, 2017-09-05 at 21:45 +0200, Thomas Meyer wrote: > >> On Tue, Sep 05, 2017 at 11:50:44AM -0700, David Miller wrote: > >> > From: Thomas Meyer > >> > Date: Sun, 03

Re: [PATCH 6/10] ixgbe: Use ARRAY_SIZE macro

2017-09-05 Thread David Miller
From: Joe Perches Date: Tue, 05 Sep 2017 13:01:18 -0700 > On Tue, 2017-09-05 at 21:45 +0200, Thomas Meyer wrote: >> On Tue, Sep 05, 2017 at 11:50:44AM -0700, David Miller wrote: >> > From: Thomas Meyer >> > Date: Sun, 03 Sep 2017 14:19:31 +0200 >> > >> > > Use ARRAY_SIZE macro, rather than expl

Re: [PATCH 6/10] ixgbe: Use ARRAY_SIZE macro

2017-09-05 Thread Joe Perches
On Tue, 2017-09-05 at 21:45 +0200, Thomas Meyer wrote: > On Tue, Sep 05, 2017 at 11:50:44AM -0700, David Miller wrote: > > From: Thomas Meyer > > Date: Sun, 03 Sep 2017 14:19:31 +0200 > > > > > Use ARRAY_SIZE macro, rather than explicitly coding some variant of it > > > yourself. > > > Found with

Re: [PATCH 6/10] ixgbe: Use ARRAY_SIZE macro

2017-09-05 Thread Thomas Meyer
On Tue, Sep 05, 2017 at 11:50:44AM -0700, David Miller wrote: > From: Thomas Meyer > Date: Sun, 03 Sep 2017 14:19:31 +0200 > > > Use ARRAY_SIZE macro, rather than explicitly coding some variant of it > > yourself. > > Found with: find -type f -name "*.c" -o -name "*.h" | xargs perl -p -i -e > > '

Re: [PATCH 6/10] ixgbe: Use ARRAY_SIZE macro

2017-09-05 Thread David Miller
From: Thomas Meyer Date: Sun, 03 Sep 2017 14:19:31 +0200 > Use ARRAY_SIZE macro, rather than explicitly coding some variant of it > yourself. > Found with: find -type f -name "*.c" -o -name "*.h" | xargs perl -p -i -e > 's/\bsizeof\s*\(\s*(\w+)\s*\)\s*\ /\s*sizeof\s*\(\s*\1\s*\[\s*0\s*\]\s*\) > /

[PATCH 6/10] ixgbe: Use ARRAY_SIZE macro

2017-09-03 Thread Thomas Meyer
Use ARRAY_SIZE macro, rather than explicitly coding some variant of it yourself. Found with: find -type f -name "*.c" -o -name "*.h" | xargs perl -p -i -e 's/\bsizeof\s*\(\s*(\w+)\s*\)\s*\ /\s*sizeof\s*\(\s*\1\s*\[\s*0\s*\]\s*\) /ARRAY_SIZE(\1)/g' and manual check/verification. Signed-off-by: Thom