Re: [PATCH 6/7] Make qdisc changeable.

2007-08-06 Thread Patrick McHardy
Corey Hickey wrote: > Patrick McHardy wrote: > >>> +if ((err = sfq_q_init(&tmp, opt))) >>> +return err; >> >> >> >> This will also use defaults for all unspecified values. It would >> be more consistent with other qdiscs to only change those values >> that are actually specified, so so

Re: [PATCH 6/7] Make qdisc changeable.

2007-08-05 Thread Corey Hickey
Patrick McHardy wrote: + if ((err = sfq_q_init(&tmp, opt))) + return err; This will also use defaults for all unspecified values. It would be more consistent with other qdiscs to only change those values that are actually specified, so something like "tc qdisc change ... pe

Re: [PATCH 6/7] Make qdisc changeable.

2007-07-31 Thread Corey Hickey
Patrick McHardy wrote: Corey Hickey wrote: Re-implement sfq_change() and enable Qdisc_opts.change so "tc qdisc change" will work. Signed-off-by: Corey Hickey <[EMAIL PROTECTED]> --- net/sched/sch_sfq.c | 51 ++- 1 files changed, 50 insertions(+

Re: [PATCH 6/7] Make qdisc changeable.

2007-07-30 Thread Patrick McHardy
Corey Hickey wrote: > Re-implement sfq_change() and enable Qdisc_opts.change so "tc qdisc > change" will work. > > Signed-off-by: Corey Hickey <[EMAIL PROTECTED]> > --- > net/sched/sch_sfq.c | 51 > ++- > 1 files changed, 50 insertions(+), 1 dele

[PATCH 6/7] Make qdisc changeable.

2007-07-29 Thread Corey Hickey
Re-implement sfq_change() and enable Qdisc_opts.change so "tc qdisc change" will work. Signed-off-by: Corey Hickey <[EMAIL PROTECTED]> --- net/sched/sch_sfq.c | 51 ++- 1 files changed, 50 insertions(+), 1 deletions(-) diff --git a/net/sched/sch_

[PATCH 6/7] Make qdisc changeable.

2007-07-29 Thread Corey Hickey
Re-implement sfq_change() and enable Qdisc_opts.change so "tc qdisc change" will work. Signed-off-by: Corey Hickey <[EMAIL PROTECTED]> --- net/sched/sch_sfq.c | 51 ++- 1 files changed, 50 insertions(+), 1 deletions(-) diff --git a/net/sched/sch_