Re: [PATCH 7/7] 8139cp: Avoid gratuitous writes to TxPoll register when already running

2015-09-21 Thread David Woodhouse
On Mon, 2015-09-21 at 22:54 +0200, Francois Romieu wrote: > David Woodhouse : > [...] > > I'm actually having second thoughts about this one since realising that > > QEMU doesn't implement it correctly. The workaround isn't *that* horrid > > but it's not clear it's enough of a performance win — or

Re: [PATCH 7/7] 8139cp: Avoid gratuitous writes to TxPoll register when already running

2015-09-21 Thread Francois Romieu
David Woodhouse : [...] > I'm actually having second thoughts about this one since realising that > QEMU doesn't implement it correctly. The workaround isn't *that* horrid > but it's not clear it's enough of a performance win — or whether it's > entirely necessary for catching my TX stall. It don

[PATCH 7/7] 8139cp: Avoid gratuitous writes to TxPoll register when already running

2015-09-21 Thread David Woodhouse
From: David Woodhouse This is a minor optimisation, but as a side-effect it means we can know precisely which descriptors were already in the ring when we last prodded it to run. This will give us a better chance to catch the case where we get a TxEmpty interrupt when it hasn't actually finished