Re: [PATCH 9/9] NetXen 1G/10G driver

2006-04-05 Thread Bryan O'Sullivan
On Sat, 2006-04-01 at 05:20 -0800, Linsys Contractor Amit S. Kale wrote: > +U16 brdnum; Where does U16 come from? > +#define MAX_CMD_DESCRIPTORS 1024 Same comment as before WRT generic macro names. You're certain to break the kernel build at some point with all these names.

Re: [PATCH 9/9] NetXen 1G/10G driver

2006-04-03 Thread Francois Romieu
Linsys Contractor Amit S. Kale <[EMAIL PROTECTED]> : > diff -Naru linux-2.6.16_orig/drivers/net/netxen/netxen_brdcfg.h > linux-2.6.16/drivers/net/netxen/netxen_brdcfg.h > --- linux-2.6.16_orig/drivers/net/netxen/netxen_brdcfg.h 1969-12-31 > 16:00:00.0 -0800 > +++ linux-2.6.16/drivers

[PATCH 9/9] NetXen 1G/10G driver

2006-04-01 Thread Linsys Contractor Amit S. Kale
diff -Naru linux-2.6.16_orig/drivers/net/netxen/netxen_brdcfg.h linux-2.6.16/drivers/net/netxen/netxen_brdcfg.h --- linux-2.6.16_orig/drivers/net/netxen/netxen_brdcfg.h1969-12-31 16:00:00.0 -0800 +++ linux-2.6.16/drivers/net/netxen/netxen_brdcfg.h 2006-03-24 14:13:57.