Re: [PATCH RFC 04/11] net/mlx5e: Build RX SKB on demand

2016-09-18 Thread Tariq Toukan
Hi Alexei, On 07/09/2016 8:34 PM, Alexei Starovoitov wrote: On Wed, Sep 07, 2016 at 03:42:25PM +0300, Saeed Mahameed wrote: For non-striding RQ configuration before this patch we had a ring with pre-allocated SKBs and mapped the SKB->data buffers for device. For robustness and better RX data b

Re: [PATCH RFC 04/11] net/mlx5e: Build RX SKB on demand

2016-09-07 Thread Jesper Dangaard Brouer
On Wed, 7 Sep 2016 15:42:25 +0300 Saeed Mahameed wrote: > For non-striding RQ configuration before this patch we had a ring > with pre-allocated SKBs and mapped the SKB->data buffers for > device. > > For robustness and better RX data buffers management, we allocate a > page per packet and bui

Re: [PATCH RFC 04/11] net/mlx5e: Build RX SKB on demand

2016-09-07 Thread Alexei Starovoitov
On Wed, Sep 07, 2016 at 03:42:25PM +0300, Saeed Mahameed wrote: > For non-striding RQ configuration before this patch we had a ring > with pre-allocated SKBs and mapped the SKB->data buffers for > device. > > For robustness and better RX data buffers management, we allocate a > page per packet and

[PATCH RFC 04/11] net/mlx5e: Build RX SKB on demand

2016-09-07 Thread Saeed Mahameed
For non-striding RQ configuration before this patch we had a ring with pre-allocated SKBs and mapped the SKB->data buffers for device. For robustness and better RX data buffers management, we allocate a page per packet and build_skb around it. This patch (which is a prerequisite for XDP) will act