Re: [PATCH RFC 1/3] net: Add dev_set_env_hdr_len to accept envelope frames

2016-09-27 Thread Toshiaki Makita
On 2016/09/27 23:23, Mintz, Yuval wrote: >> +/* return envelope header length */ >> +static inline int netif_get_env_hdr_len(struct net_device *dev) { >> +if (dev->netdev_ops->ndo_set_env_hdr_len) >> +return dev->env_hdr_len; >> + >> +if (netif_reduces_vlan_mtu(dev)) >> +

RE: [PATCH RFC 1/3] net: Add dev_set_env_hdr_len to accept envelope frames

2016-09-27 Thread Mintz, Yuval
> +/* return envelope header length */ > +static inline int netif_get_env_hdr_len(struct net_device *dev) { > + if (dev->netdev_ops->ndo_set_env_hdr_len) > + return dev->env_hdr_len; > + > + if (netif_reduces_vlan_mtu(dev)) > + return 0; > + > + return 4; /* VLAN

[PATCH RFC 1/3] net: Add dev_set_env_hdr_len to accept envelope frames

2016-09-27 Thread Toshiaki Makita
Currently most NICs support Q-tagged frames[1], i.e. 1522 bytes frames to handle 4 bytes VLAN header. But some encapsulation protocols like 802.1ad requires them to handle larger frames. This change introduces dev_set_env_hdr_len() and corresponding drivers' operation .ndo_set_env_hdr_len(), which