All these PHY basics are handled by phylib, so let's remove this code.

Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
 drivers/net/ethernet/realtek/r8168.c | 92 ------------------------------------
 1 file changed, 92 deletions(-)

diff --git a/drivers/net/ethernet/realtek/r8168.c 
b/drivers/net/ethernet/realtek/r8168.c
index 6b398915f..f88fc0fa0 100644
--- a/drivers/net/ethernet/realtek/r8168.c
+++ b/drivers/net/ethernet/realtek/r8168.c
@@ -1843,91 +1843,6 @@ static int rtl8168_get_regs_len(struct net_device *dev)
        return R8168_REGS_SIZE;
 }
 
-static int rtl8168_set_speed_xmii(struct net_device *dev,
-                                 u8 autoneg, u16 speed, u8 duplex, u32 adv)
-{
-       struct rtl8168_private *tp = netdev_priv(dev);
-       int giga_ctrl, bmcr;
-       int rc = -EINVAL;
-
-       rtl_writephy(tp, 0x1f, 0x0000);
-
-       if (autoneg == AUTONEG_ENABLE) {
-               int auto_nego;
-
-               auto_nego = rtl_readphy(tp, MII_ADVERTISE);
-               auto_nego &= ~(ADVERTISE_10HALF | ADVERTISE_10FULL |
-                               ADVERTISE_100HALF | ADVERTISE_100FULL);
-
-               if (adv & ADVERTISED_10baseT_Half)
-                       auto_nego |= ADVERTISE_10HALF;
-               if (adv & ADVERTISED_10baseT_Full)
-                       auto_nego |= ADVERTISE_10FULL;
-               if (adv & ADVERTISED_100baseT_Half)
-                       auto_nego |= ADVERTISE_100HALF;
-               if (adv & ADVERTISED_100baseT_Full)
-                       auto_nego |= ADVERTISE_100FULL;
-
-               auto_nego |= ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM;
-
-               giga_ctrl = rtl_readphy(tp, MII_CTRL1000);
-               giga_ctrl &= ~(ADVERTISE_1000FULL | ADVERTISE_1000HALF);
-
-               /* The 8100e/8101e/8102e do Fast Ethernet only. */
-               if (tp->mii.supports_gmii) {
-                       if (adv & ADVERTISED_1000baseT_Half)
-                               giga_ctrl |= ADVERTISE_1000HALF;
-                       if (adv & ADVERTISED_1000baseT_Full)
-                               giga_ctrl |= ADVERTISE_1000FULL;
-               } else if (adv & (ADVERTISED_1000baseT_Half |
-                                 ADVERTISED_1000baseT_Full)) {
-                       netif_info(tp, link, dev,
-                                  "PHY does not support 1000Mbps\n");
-                       goto out;
-               }
-
-               bmcr = BMCR_ANENABLE | BMCR_ANRESTART;
-
-               rtl_writephy(tp, MII_ADVERTISE, auto_nego);
-               rtl_writephy(tp, MII_CTRL1000, giga_ctrl);
-       } else {
-               if (speed == SPEED_10)
-                       bmcr = 0;
-               else if (speed == SPEED_100)
-                       bmcr = BMCR_SPEED100;
-               else
-                       goto out;
-
-               if (duplex == DUPLEX_FULL)
-                       bmcr |= BMCR_FULLDPLX;
-       }
-
-       rtl_writephy(tp, MII_BMCR, bmcr);
-
-       rc = 0;
-out:
-       return rc;
-}
-
-static int rtl8168_set_speed(struct net_device *dev,
-                            u8 autoneg, u16 speed, u8 duplex, u32 advertising)
-{
-       struct rtl8168_private *tp = netdev_priv(dev);
-       int ret;
-
-       ret = rtl8168_set_speed_xmii(dev, autoneg, speed, duplex, advertising);
-       if (ret < 0)
-               goto out;
-
-       if (netif_running(dev) && (autoneg == AUTONEG_ENABLE) &&
-           (advertising & ADVERTISED_1000baseT_Full) &&
-           !pci_is_pcie(tp->pci_dev)) {
-               mod_timer(&tp->timer, jiffies + RTL8168_PHY_TIMEOUT);
-       }
-out:
-       return ret;
-}
-
 static netdev_features_t rtl8168_fix_features(struct net_device *dev,
        netdev_features_t features)
 {
@@ -4264,13 +4179,6 @@ static void rtl8168_init_phy(struct net_device *dev, 
struct rtl8168_private *tp)
        pci_write_config_byte(tp->pci_dev, PCI_LATENCY_TIMER, 0x40);
 
        genphy_soft_reset(dev->phydev);
-
-       rtl8168_set_speed(dev, AUTONEG_ENABLE, SPEED_1000, DUPLEX_FULL,
-                         ADVERTISED_10baseT_Half | ADVERTISED_10baseT_Full |
-                         ADVERTISED_100baseT_Half | ADVERTISED_100baseT_Full |
-                         (tp->mii.supports_gmii ?
-                          ADVERTISED_1000baseT_Half |
-                          ADVERTISED_1000baseT_Full : 0));
 }
 
 static void rtl_rar_set(struct rtl8168_private *tp, u8 *addr)
-- 
2.15.1


Reply via email to