Re: [PATCH RFC net-next] bnx2x: avoid printing unnecessary messages during register dump

2016-09-29 Thread David Miller
From: "Guilherme G. Piccoli" Date: Thu, 29 Sep 2016 13:19:39 -0300 > David, thanks for your comment. I confess I didn't understand your > statement quite well. You say we shouldn't dump registers that will > cause timeouts, that's it? Yes, basically. If this happened infrequently for one or two

Re: [PATCH RFC net-next] bnx2x: avoid printing unnecessary messages during register dump

2016-09-29 Thread Guilherme G. Piccoli
On 09/27/2016 11:43 PM, David Miller wrote: > From: "Guilherme G. Piccoli" > Date: Tue, 27 Sep 2016 15:33:54 -0300 > >> The bnx2x driver prints multiple error messages during register dump, >> with "ethtool -d" for example. The driver even warn that many messages >> might be seen during the reg

Re: [PATCH RFC net-next] bnx2x: avoid printing unnecessary messages during register dump

2016-09-27 Thread David Miller
From: "Guilherme G. Piccoli" Date: Tue, 27 Sep 2016 15:33:54 -0300 > The bnx2x driver prints multiple error messages during register dump, > with "ethtool -d" for example. The driver even warn that many messages > might be seen during the register dump, but they are harmless. A typical > kernel l

[PATCH RFC net-next] bnx2x: avoid printing unnecessary messages during register dump

2016-09-27 Thread Guilherme G. Piccoli
The bnx2x driver prints multiple error messages during register dump, with "ethtool -d" for example. The driver even warn that many messages might be seen during the register dump, but they are harmless. A typical kernel log after register dump looks like this: [9.375] bnx2x: [bnx2x_get_regs:987