>> This changes the semantics of these fields. Please add a new SO_EE_CODE flag,
>> even if the semantics can be derived from the packet family (for now).
>
> sounds good, I'll take care of this (and other review comments)
> for the next rev.
>
>> Even better would be if we can avoid the cookies
On (01/17/18 19:23), Willem de Bruijn wrote:
> > +static void rds_rm_zerocopy_callback(struct rds_sock *rs)
:
> > + skb = alloc_skb(ncookies * sizeof(u32), GFP_ATOMIC);
>
> TCP zerocopy avoids this issue by allocating the notification skb when the
> zerocopy packet is created, which
On Wed, Jan 17, 2018 at 7:20 AM, Sowmini Varadhan
wrote:
> RDS removes a datagram from the retransmit queue when an ACK is
> received. The ACK indicates that the receiver has queued the
> RDS datagram, so that the sender can safely forget the datagram.
>
> If the
RDS removes a datagram from the retransmit queue when an ACK is
received. The ACK indicates that the receiver has queued the
RDS datagram, so that the sender can safely forget the datagram.
If the datagram to be removed had pinned pages set up, add
an entry to the rs->rs_znotify_queue so that the