Re: [PATCH RFC net-next v3 4/7] net: use skb->csum_algo to identify packets needing crc32c

2017-04-13 Thread Davide Caratti
thank you, On Fri, 2017-04-07 at 08:43 -0700, Tom Herbert wrote: > Maybe just call it csum_not_ip then. Then just do "if > (unlikely(skb->csum_not_ip)) ..." OK, I will rename the bit, avoid the enum and use the 'unlikely'. Up to now, this series uses the bit for SCTP only and leaves unmodified be

Re: [PATCH RFC net-next v3 4/7] net: use skb->csum_algo to identify packets needing crc32c

2017-04-07 Thread Tom Herbert
On Fri, Apr 7, 2017 at 10:29 AM, Davide Caratti wrote: > hello Tom, > > On Fri, 2017-04-07 at 08:43 -0700, Tom Herbert wrote: >> On Fri, Apr 7, 2017 at 7:16 AM, Davide Caratti wrote: >> > @@ -742,8 +744,10 @@ struct sk_buff { >> > __u8csum_valid:1; >> > __u8

Re: [PATCH RFC net-next v3 4/7] net: use skb->csum_algo to identify packets needing crc32c

2017-04-07 Thread Davide Caratti
hello Tom, On Fri, 2017-04-07 at 08:43 -0700, Tom Herbert wrote: > On Fri, Apr 7, 2017 at 7:16 AM, Davide Caratti wrote: > > @@ -742,8 +744,10 @@ struct sk_buff { > > __u8csum_valid:1; > > __u8csum_complete_sw:1; > > __u8

Re: [PATCH RFC net-next v3 4/7] net: use skb->csum_algo to identify packets needing crc32c

2017-04-07 Thread Tom Herbert
On Fri, Apr 7, 2017 at 7:16 AM, Davide Caratti wrote: > skb->csum_algo carries the indication on which algorithm is needed to > compute checksum on skb in the transmit path, when skb->ip_summed is > equal to CHECKSUM_PARTIAL. If skb carries a SCTP packet and crc32c > hasn't been yet written in L4

[PATCH RFC net-next v3 4/7] net: use skb->csum_algo to identify packets needing crc32c

2017-04-07 Thread Davide Caratti
skb->csum_algo carries the indication on which algorithm is needed to compute checksum on skb in the transmit path, when skb->ip_summed is equal to CHECKSUM_PARTIAL. If skb carries a SCTP packet and crc32c hasn't been yet written in L4 header, skb->csum_algo is assigned to CRC32C_CHECKSUM. In any o