[PATCH V2] ifcvf: move IRQ request/free to status change handlers

2020-05-12 Thread Zhu Lingshan
This commit move IRQ request and free operations from probe() to VIRTIO status change handler to comply with VIRTIO spec. VIRTIO spec 1.1, section 2.1.2 Device Requirements: Device Status Field The device MUST NOT consume buffers or send any used buffer notifications to the driver before DRIVER_OK

Re: [PATCH V2] ifcvf: move IRQ request/free to status change handlers

2020-05-12 Thread Jason Wang
On 2020/5/12 下午4:00, Zhu Lingshan wrote: This commit move IRQ request and free operations from probe() to VIRTIO status change handler to comply with VIRTIO spec. VIRTIO spec 1.1, section 2.1.2 Device Requirements: Device Status Field The device MUST NOT consume buffers or send any used buffer

Re: [PATCH V2] ifcvf: move IRQ request/free to status change handlers

2020-05-12 Thread Jason Wang
On 2020/5/13 下午12:42, Zhu, Lingshan wrote: On 5/13/2020 12:12 PM, Jason Wang wrote: On 2020/5/12 下午4:00, Zhu Lingshan wrote: This commit move IRQ request and free operations from probe() to VIRTIO status change handler to comply with VIRTIO spec. VIRTIO spec 1.1, section 2.1.2 Device Requ

Re: [PATCH V2] ifcvf: move IRQ request/free to status change handlers

2020-05-13 Thread Jason Wang
On 2020/5/13 下午12:42, Zhu, Lingshan wrote: On 5/13/2020 12:12 PM, Jason Wang wrote: On 2020/5/12 下午4:00, Zhu Lingshan wrote: This commit move IRQ request and free operations from probe() to VIRTIO status change handler to comply with VIRTIO spec. VIRTIO spec 1.1, section 2.1.2 Device Requ

Re: [PATCH V2] ifcvf: move IRQ request/free to status change handlers

2020-05-18 Thread Cindy Lu
Hi ,Jason It works ok in the latest version of qemu vdpa code , So I think the patch is ok. Thanks Cindy On Wed, May 13, 2020 at 3:18 PM Jason Wang wrote: > > > On 2020/5/13 下午12:42, Zhu, Lingshan wrote: > > > > > > On 5/13/2020 12:12 PM, Jason Wang wrote: > >> > >> On 2020/5/12 下午4:00, Zhu Lingsh

Re: [PATCH V2] ifcvf: move IRQ request/free to status change handlers

2020-05-18 Thread Jason Wang
On 2020/5/19 上午9:51, Cindy Lu wrote: Hi ,Jason It works ok in the latest version of qemu vdpa code , So I think the patch is ok. Thanks Cindy Thanks for the testing, (btw, we'd better not do top posting when discuss in the community). So, Acked-by: Jason Wang On Wed, May 13, 2020 at