Re: [PATCH V2 3/4] net-next: dsa: fix flow dissection

2017-07-28 Thread Andrew Lunn
> thanks for the feedback. should I add 2 callbacks for each of the 2 > parameters ? Hi John A single callback is better. We don't want to have to peek into the packet twice to determine two values. Andrew

Re: [PATCH V2 3/4] net-next: dsa: fix flow dissection

2017-07-28 Thread John Crispin
On 26/07/17 17:10, Andrew Lunn wrote: On Fri, Jul 21, 2017 at 10:58:12AM +0200, John Crispin wrote: RPS and probably other kernel features are currently broken on some if not all DSA devices. The root cause of this is that skb_hash will call the flow_dissector. At this point the skb still cont

Re: [PATCH V2 3/4] net-next: dsa: fix flow dissection

2017-07-26 Thread Andrew Lunn
On Fri, Jul 21, 2017 at 10:58:12AM +0200, John Crispin wrote: > RPS and probably other kernel features are currently broken on some if not > all DSA devices. The root cause of this is that skb_hash will call the > flow_dissector. At this point the skb still contains the magic switch header > and th

Re: [PATCH V2 3/4] net-next: dsa: fix flow dissection

2017-07-23 Thread kbuild test robot
Hi John, [auto build test ERROR on net-next/master] [also build test ERROR on v4.13-rc1 next-20170721] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/John-Crispin/net-next-dsa-move-struct-dsa_de

[PATCH V2 3/4] net-next: dsa: fix flow dissection

2017-07-21 Thread John Crispin
RPS and probably other kernel features are currently broken on some if not all DSA devices. The root cause of this is that skb_hash will call the flow_dissector. At this point the skb still contains the magic switch header and the skb->protocol field is not set up to the correct 802.3 value yet. By