Re: [PATCH V2 bpf] xdp: add NULL pointer check in __xdp_return()

2018-07-26 Thread Taehee Yoo
2018-07-26 21:07 GMT+09:00 Björn Töpel : > Den tors 26 juli 2018 kl 04:14 skrev Jakub Kicinski > : >> >> On Thu, 26 Jul 2018 00:09:50 +0900, Taehee Yoo wrote: >> > rhashtable_lookup() can return NULL. so that NULL pointer >> > check routine should be added. >> > >> > Fixes: 02b55e5657c3 ("xdp: add

Re: [PATCH V2 bpf] xdp: add NULL pointer check in __xdp_return()

2018-07-26 Thread Taehee Yoo
2018-07-26 11:11 GMT+09:00 Jakub Kicinski : > On Thu, 26 Jul 2018 00:09:50 +0900, Taehee Yoo wrote: >> rhashtable_lookup() can return NULL. so that NULL pointer >> check routine should be added. >> >> Fixes: 02b55e5657c3 ("xdp: add MEM_TYPE_ZERO_COPY") >> Signed-off-by: Taehee Yoo >> --- >> V2 :

Re: [PATCH V2 bpf] xdp: add NULL pointer check in __xdp_return()

2018-07-26 Thread Björn Töpel
Den tors 26 juli 2018 kl 04:14 skrev Jakub Kicinski : > > On Thu, 26 Jul 2018 00:09:50 +0900, Taehee Yoo wrote: > > rhashtable_lookup() can return NULL. so that NULL pointer > > check routine should be added. > > > > Fixes: 02b55e5657c3 ("xdp: add MEM_TYPE_ZERO_COPY") > > Signed-off-by: Taehee Yoo

Re: [PATCH V2 bpf] xdp: add NULL pointer check in __xdp_return()

2018-07-25 Thread Jakub Kicinski
On Thu, 26 Jul 2018 00:09:50 +0900, Taehee Yoo wrote: > rhashtable_lookup() can return NULL. so that NULL pointer > check routine should be added. > > Fixes: 02b55e5657c3 ("xdp: add MEM_TYPE_ZERO_COPY") > Signed-off-by: Taehee Yoo > --- > V2 : add WARN_ON_ONCE when xa is NULL. > >

Re: [PATCH V2 bpf] xdp: add NULL pointer check in __xdp_return()

2018-07-25 Thread Martin KaFai Lau
On Thu, Jul 26, 2018 at 12:09:50AM +0900, Taehee Yoo wrote: > rhashtable_lookup() can return NULL. so that NULL pointer > check routine should be added. > > Fixes: 02b55e5657c3 ("xdp: add MEM_TYPE_ZERO_COPY") > Signed-off-by: Taehee Yoo Acked-by: Martin KaFai Lau > --- > V2 : add WARN_ON_ONCE

[PATCH V2 bpf] xdp: add NULL pointer check in __xdp_return()

2018-07-25 Thread Taehee Yoo
rhashtable_lookup() can return NULL. so that NULL pointer check routine should be added. Fixes: 02b55e5657c3 ("xdp: add MEM_TYPE_ZERO_COPY") Signed-off-by: Taehee Yoo --- V2 : add WARN_ON_ONCE when xa is NULL. net/core/xdp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git