Re: [PATCH V2 net] net: fix tcp reset packet flowlabel for ipv6

2017-07-25 Thread Shaohua Li
On Mon, Jul 24, 2017 at 01:34:55PM -0700, David Miller wrote: > From: Shaohua Li > Date: Tue, 18 Jul 2017 12:03:37 -0700 > > > + /* Since this is being sent on the wire obfuscate hash a bit > > +* to minimize possbility that any useful information to an > > +* attacker

Re: [PATCH V2 net] net: fix tcp reset packet flowlabel for ipv6

2017-07-25 Thread Shaohua Li
On Mon, Jul 24, 2017 at 04:12:53PM -0700, Cong Wang wrote: > On Mon, Jul 24, 2017 at 1:34 PM, David Miller wrote: > > From: Shaohua Li > > Date: Tue, 18 Jul 2017 12:03:37 -0700 > > > >> + /* Since this is being sent on the wire obfuscate hash a bit > >>

Re: [PATCH V2 net] net: fix tcp reset packet flowlabel for ipv6

2017-07-24 Thread Cong Wang
On Mon, Jul 24, 2017 at 1:34 PM, David Miller wrote: > From: Shaohua Li > Date: Tue, 18 Jul 2017 12:03:37 -0700 > >> + /* Since this is being sent on the wire obfuscate hash a bit >> + * to minimize possbility that any useful information to an >> +

Re: [PATCH V2 net] net: fix tcp reset packet flowlabel for ipv6

2017-07-24 Thread David Miller
From: Shaohua Li Date: Tue, 18 Jul 2017 12:03:37 -0700 > + /* Since this is being sent on the wire obfuscate hash a bit > + * to minimize possbility that any useful information to an > + * attacker is leaked. Only lower 20 bits are relevant. > + */ > +

[PATCH V2 net] net: fix tcp reset packet flowlabel for ipv6

2017-07-18 Thread Shaohua Li
From: Shaohua Li Please see below tcpdump output: 21:00:48.109122 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload length: 40) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.: Flags [S], cksum 0x0529 (incorrect -> 0xf56c), seq 3282214508, win 43690,