Re: [PATCH V2 net] netdevice: Include NETIF_F_HW_CSUM when intersecting features

2017-04-21 Thread Alexander Duyck
On Fri, Apr 21, 2017 at 10:33 AM, Vladislav Yasevich wrote: > On Fri, Apr 21, 2017 at 1:33 AM, Michal Kubecek wrote: >> On Thu, Apr 20, 2017 at 07:19:55PM -0400, Vlad Yasevich wrote: >>> >>> Having said that, the other alternative is to inherit hw_features from >>> lower devices. BTW, bonding I

Re: [PATCH V2 net] netdevice: Include NETIF_F_HW_CSUM when intersecting features

2017-04-21 Thread Vladislav Yasevich
On Fri, Apr 21, 2017 at 1:33 AM, Michal Kubecek wrote: > On Thu, Apr 20, 2017 at 07:19:55PM -0400, Vlad Yasevich wrote: >> >> Having said that, the other alternative is to inherit hw_features from >> lower devices. BTW, bonding I think has a similar "issue" you are >> describing since it prefers

Re: [PATCH V2 net] netdevice: Include NETIF_F_HW_CSUM when intersecting features

2017-04-20 Thread Michal Kubecek
On Thu, Apr 20, 2017 at 07:19:55PM -0400, Vlad Yasevich wrote: > > Having said that, the other alternative is to inherit hw_features from > lower devices. BTW, bonding I think has a similar "issue" you are > describing since it prefers HW_CSUM if any of the slaves have it set. It does but bondin

Re: [PATCH V2 net] netdevice: Include NETIF_F_HW_CSUM when intersecting features

2017-04-20 Thread Alexander Duyck
On Thu, Apr 20, 2017 at 4:19 PM, Vlad Yasevich wrote: > On 04/20/2017 06:31 PM, Alexander Duyck wrote: >> On Thu, Apr 20, 2017 at 12:17 PM, Vladislav Yasevich >> wrote: >>> While hardware device use either NETIF_F_(IP|IPV6)_CSUM or >>> NETIF_F_HW_CSUM, all of the software devices use HW_CSUM. >>>

Re: [PATCH V2 net] netdevice: Include NETIF_F_HW_CSUM when intersecting features

2017-04-20 Thread Vlad Yasevich
On 04/20/2017 06:31 PM, Alexander Duyck wrote: > On Thu, Apr 20, 2017 at 12:17 PM, Vladislav Yasevich > wrote: >> While hardware device use either NETIF_F_(IP|IPV6)_CSUM or >> NETIF_F_HW_CSUM, all of the software devices use HW_CSUM. >> This results in an interesting situation when the software >>

Re: [PATCH V2 net] netdevice: Include NETIF_F_HW_CSUM when intersecting features

2017-04-20 Thread Alexander Duyck
On Thu, Apr 20, 2017 at 12:17 PM, Vladislav Yasevich wrote: > While hardware device use either NETIF_F_(IP|IPV6)_CSUM or > NETIF_F_HW_CSUM, all of the software devices use HW_CSUM. > This results in an interesting situation when the software > device is configured on top of hw device using (IP|IPV

[PATCH V2 net] netdevice: Include NETIF_F_HW_CSUM when intersecting features

2017-04-20 Thread Vladislav Yasevich
While hardware device use either NETIF_F_(IP|IPV6)_CSUM or NETIF_F_HW_CSUM, all of the software devices use HW_CSUM. This results in an interesting situation when the software device is configured on top of hw device using (IP|IPV6)_CSUM. In this situation, the user can't turn off checksum offloadi