Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-10 Thread Björn Töpel
Den fre 7 dec. 2018 kl 12:44 skrev Björn Töpel : > > From: Björn Töpel > > Hi! > > This patch set adds support for a new XDP socket bind option, > XDP_ATTACH. > > The rationale behind attach is performance and ease of use. Many XDP > socket users just need a simple way of creating/binding a socket

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-08 Thread Andrew Lunn
> That is not how XDP works. XDP must run on the "master" physical driver > interface, as the "slave" interface is a virtual DSA interface. I did > mention DSA because I'm handling that on the EspressoBin implementation. Hi Jesper It is going to be interesting to see how you do that. As a user,

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-08 Thread Jesper Dangaard Brouer
On Sat, 8 Dec 2018 19:43:38 +0100 Björn Töpel wrote: > Den lör 8 dec. 2018 kl 15:52 skrev Jesper Dangaard Brouer : > > > > On Fri, 7 Dec 2018 15:01:55 +0100 > > Björn Töpel wrote: > > > > > Den fre 7 dec. 2018 kl 14:42 skrev Jesper Dangaard Brouer > > > : > > > > > > > > On Fri, 7 Dec 2018

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-08 Thread Jesper Dangaard Brouer
On Sat, 8 Dec 2018 17:55:05 +0100 Andrew Lunn wrote: > On Sat, Dec 08, 2018 at 04:12:12PM +0100, Jesper Dangaard Brouer wrote: > > On Fri, 7 Dec 2018 13:21:08 -0800 > > Alexei Starovoitov wrote: > > > > > for production I suspect the users would want > > > an easy way to stay safe when they'r

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-08 Thread Björn Töpel
Den lör 8 dec. 2018 kl 16:12 skrev Jesper Dangaard Brouer : > > On Fri, 7 Dec 2018 13:21:08 -0800 > Alexei Starovoitov wrote: > > > for production I suspect the users would want > > an easy way to stay safe when they're playing with AF_XDP. > > So another builtin program that redirects ssh and pin

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-08 Thread Björn Töpel
Den lör 8 dec. 2018 kl 15:52 skrev Jesper Dangaard Brouer : > > On Fri, 7 Dec 2018 15:01:55 +0100 > Björn Töpel wrote: > > > Den fre 7 dec. 2018 kl 14:42 skrev Jesper Dangaard Brouer > > : > > > > > > On Fri, 7 Dec 2018 12:44:24 +0100 > > > Björn Töpel wrote: > > > > > > > The rationale behind

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-08 Thread Andrew Lunn
On Sat, Dec 08, 2018 at 04:12:12PM +0100, Jesper Dangaard Brouer wrote: > On Fri, 7 Dec 2018 13:21:08 -0800 > Alexei Starovoitov wrote: > > > for production I suspect the users would want > > an easy way to stay safe when they're playing with AF_XDP. > > So another builtin program that redirects

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-08 Thread Jesper Dangaard Brouer
On Fri, 7 Dec 2018 13:21:08 -0800 Alexei Starovoitov wrote: > for production I suspect the users would want > an easy way to stay safe when they're playing with AF_XDP. > So another builtin program that redirects ssh and ping traffic > back to the kernel would be a nice addition. Are you saying

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-08 Thread Jesper Dangaard Brouer
On Fri, 7 Dec 2018 15:01:55 +0100 Björn Töpel wrote: > Den fre 7 dec. 2018 kl 14:42 skrev Jesper Dangaard Brouer : > > > > On Fri, 7 Dec 2018 12:44:24 +0100 > > Björn Töpel wrote: > > > > > The rationale behind attach is performance and ease of use. Many XDP > > > socket users just need a sim

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-08 Thread Björn Töpel
Den fre 7 dec. 2018 kl 22:21 skrev Alexei Starovoitov : > > On Fri, Dec 07, 2018 at 12:44:24PM +0100, Björn Töpel wrote: > > From: Björn Töpel > > > > Hi! > > > > This patch set adds support for a new XDP socket bind option, > > XDP_ATTACH. > > > > The rationale behind attach is performance and ea

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-07 Thread Alexei Starovoitov
On Fri, Dec 07, 2018 at 12:44:24PM +0100, Björn Töpel wrote: > From: Björn Töpel > > Hi! > > This patch set adds support for a new XDP socket bind option, > XDP_ATTACH. > > The rationale behind attach is performance and ease of use. Many XDP > socket users just need a simple way of creating/bin

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-07 Thread Björn Töpel
Den fre 7 dec. 2018 kl 14:42 skrev Jesper Dangaard Brouer : > > On Fri, 7 Dec 2018 12:44:24 +0100 > Björn Töpel wrote: > > > The rationale behind attach is performance and ease of use. Many XDP > > socket users just need a simple way of creating/binding a socket and > > receiving frames right awa

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-07 Thread Björn Töpel
Den fre 7 dec. 2018 kl 14:42 skrev Jesper Dangaard Brouer : > > On Fri, 7 Dec 2018 12:44:24 +0100 > Björn Töpel wrote: > > > The rationale behind attach is performance and ease of use. Many XDP > > socket users just need a simple way of creating/binding a socket and > > receiving frames right awa

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-07 Thread Jesper Dangaard Brouer
On Fri, 7 Dec 2018 12:44:24 +0100 Björn Töpel wrote: > The rationale behind attach is performance and ease of use. Many XDP > socket users just need a simple way of creating/binding a socket and > receiving frames right away without loading an XDP program. > > XDP_ATTACH adds a mechanism we cal

[PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-07 Thread Björn Töpel
From: Björn Töpel Hi! This patch set adds support for a new XDP socket bind option, XDP_ATTACH. The rationale behind attach is performance and ease of use. Many XDP socket users just need a simple way of creating/binding a socket and receiving frames right away without loading an XDP program.