Re: [PATCH bpf-next 3/3] selftests/bpf: allow compiling BPF objects without BTF

2021-03-30 Thread Andrii Nakryiko
On Mon, Mar 29, 2021 at 11:56 AM Alexei Starovoitov wrote: > > On Sun, Mar 28, 2021 at 11:09:23PM -0700, Andrii Nakryiko wrote: > > > > BPF skeleton works just fine without BTF, if BPF programs don't use > > global data. I have no way of knowing how BPF skeleton is used in the > > wild, and specif

Re: [PATCH bpf-next 3/3] selftests/bpf: allow compiling BPF objects without BTF

2021-03-29 Thread Alexei Starovoitov
On Sun, Mar 28, 2021 at 11:09:23PM -0700, Andrii Nakryiko wrote: > > BPF skeleton works just fine without BTF, if BPF programs don't use > global data. I have no way of knowing how BPF skeleton is used in the > wild, and specifically whether it is used without BTF and > .data/.rodata. No way of k

Re: [PATCH bpf-next 3/3] selftests/bpf: allow compiling BPF objects without BTF

2021-03-28 Thread Andrii Nakryiko
On Sun, Mar 28, 2021 at 6:16 PM Alexei Starovoitov wrote: > > On Fri, Mar 26, 2021 at 9:44 AM Andrii Nakryiko > wrote: > > > Because they double the maintenance cost now and double the support > > > forever. > > > We never needed to worry about skeleton without BTF and now it would be > > > a th

Re: [PATCH bpf-next 3/3] selftests/bpf: allow compiling BPF objects without BTF

2021-03-28 Thread Alexei Starovoitov
On Fri, Mar 26, 2021 at 9:44 AM Andrii Nakryiko wrote: > > Because they double the maintenance cost now and double the support forever. > > We never needed to worry about skeleton without BTF and now it would be > > a thing ? So all tests realistically need to be doubled: with and without > > BTF

Re: [PATCH bpf-next 3/3] selftests/bpf: allow compiling BPF objects without BTF

2021-03-26 Thread Andrii Nakryiko
On Mon, Mar 22, 2021 at 10:54 AM Alexei Starovoitov wrote: > > On Mon, Mar 22, 2021 at 09:56:19AM -0700, Andrii Nakryiko wrote: > > On Sun, Mar 21, 2021 at 6:07 PM Alexei Starovoitov > > wrote: > > > > > > On Sat, Mar 20, 2021 at 10:00:57AM -0700, Andrii Nakryiko wrote: > > > > On Fri, Mar 19, 20

Re: [PATCH bpf-next 3/3] selftests/bpf: allow compiling BPF objects without BTF

2021-03-22 Thread Alexei Starovoitov
On Mon, Mar 22, 2021 at 09:56:19AM -0700, Andrii Nakryiko wrote: > On Sun, Mar 21, 2021 at 6:07 PM Alexei Starovoitov > wrote: > > > > On Sat, Mar 20, 2021 at 10:00:57AM -0700, Andrii Nakryiko wrote: > > > On Fri, Mar 19, 2021 at 7:22 PM Alexei Starovoitov > > > wrote: > > > > > > > > On Fri, Mar

Re: [PATCH bpf-next 3/3] selftests/bpf: allow compiling BPF objects without BTF

2021-03-22 Thread Andrii Nakryiko
On Sun, Mar 21, 2021 at 6:07 PM Alexei Starovoitov wrote: > > On Sat, Mar 20, 2021 at 10:00:57AM -0700, Andrii Nakryiko wrote: > > On Fri, Mar 19, 2021 at 7:22 PM Alexei Starovoitov > > wrote: > > > > > > On Fri, Mar 19, 2021 at 01:59:09PM -0700, Andrii Nakryiko wrote: > > > > Add ability to skip

Re: [PATCH bpf-next 3/3] selftests/bpf: allow compiling BPF objects without BTF

2021-03-21 Thread Alexei Starovoitov
On Sat, Mar 20, 2021 at 10:00:57AM -0700, Andrii Nakryiko wrote: > On Fri, Mar 19, 2021 at 7:22 PM Alexei Starovoitov > wrote: > > > > On Fri, Mar 19, 2021 at 01:59:09PM -0700, Andrii Nakryiko wrote: > > > Add ability to skip BTF generation for some BPF object files. This is done > > > through usi

Re: [PATCH bpf-next 3/3] selftests/bpf: allow compiling BPF objects without BTF

2021-03-20 Thread Andrii Nakryiko
On Fri, Mar 19, 2021 at 7:22 PM Alexei Starovoitov wrote: > > On Fri, Mar 19, 2021 at 01:59:09PM -0700, Andrii Nakryiko wrote: > > Add ability to skip BTF generation for some BPF object files. This is done > > through using a convention of .nobtf.c file name suffix. > > > > Also add third statical

Re: [PATCH bpf-next 3/3] selftests/bpf: allow compiling BPF objects without BTF

2021-03-19 Thread Alexei Starovoitov
On Fri, Mar 19, 2021 at 01:59:09PM -0700, Andrii Nakryiko wrote: > Add ability to skip BTF generation for some BPF object files. This is done > through using a convention of .nobtf.c file name suffix. > > Also add third statically linked file to static_linked selftest. This file has > no BTF, caus

[PATCH bpf-next 3/3] selftests/bpf: allow compiling BPF objects without BTF

2021-03-19 Thread Andrii Nakryiko
Add ability to skip BTF generation for some BPF object files. This is done through using a convention of .nobtf.c file name suffix. Also add third statically linked file to static_linked selftest. This file has no BTF, causing resulting object file to have only some of DATASEC BTF types. It also i