[PATCH bpf-next V4 2/5] bpf: bpf_fib_lookup return MTU value as output when looked up

2020-10-27 Thread Jesper Dangaard Brouer
The BPF-helpers for FIB lookup (bpf_xdp_fib_lookup and bpf_skb_fib_lookup) can perform MTU check and return BPF_FIB_LKUP_RET_FRAG_NEEDED. The BPF-prog don't know the MTU value that caused this rejection. If the BPF-prog wants to implement PMTU (Path MTU Discovery) (rfc1191) it need to know this M

Re: [PATCH bpf-next V4 2/5] bpf: bpf_fib_lookup return MTU value as output when looked up

2020-10-27 Thread David Ahern
On 10/27/20 10:26 AM, Jesper Dangaard Brouer wrote: > The BPF-helpers for FIB lookup (bpf_xdp_fib_lookup and bpf_skb_fib_lookup) > can perform MTU check and return BPF_FIB_LKUP_RET_FRAG_NEEDED. The BPF-prog > don't know the MTU value that caused this rejection. > > If the BPF-prog wants to implem

Re: [PATCH bpf-next V4 2/5] bpf: bpf_fib_lookup return MTU value as output when looked up

2020-10-28 Thread Dan Carpenter
Hi Jesper, url: https://github.com/0day-ci/linux/commits/Jesper-Dangaard-Brouer/bpf-New-approach-for-BPF-MTU-handling/20201028-002919 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master config: i386-randconfig-m021-20201026 (attached as .config) compiler: gcc-9 (Debian 9

Re: [PATCH bpf-next V4 2/5] bpf: bpf_fib_lookup return MTU value as output when looked up

2020-10-30 Thread Jesper Dangaard Brouer
On Wed, 28 Oct 2020 15:49:42 +0300 Dan Carpenter wrote: > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter > > New smatch warnings: > net/core/filter.c:5395 bpf_ipv4_fib_lookup() error: uninitialized symbol > 'mtu'. I

Re: [PATCH bpf-next V4 2/5] bpf: bpf_fib_lookup return MTU value as output when looked up

2020-10-30 Thread Jesper Dangaard Brouer
On Tue, 27 Oct 2020 11:15:31 -0600 David Ahern wrote: > On 10/27/20 10:26 AM, Jesper Dangaard Brouer wrote: > > The BPF-helpers for FIB lookup (bpf_xdp_fib_lookup and bpf_skb_fib_lookup) > > can perform MTU check and return BPF_FIB_LKUP_RET_FRAG_NEEDED. The BPF-prog > > don't know the MTU value