Re: [PATCH ethtool v2] ethtool: Fix uninitialized variable use at qsfp dump

2018-10-04 Thread John W. Linville
On Tue, Oct 02, 2018 at 10:24:19AM +0300, Eran Ben Elisha wrote: > Struct sff_diags can be used uninitialized at sff8636_show_dom, this > caused the tool to show unreported fields (supports_alarms) by the lower > level driver. > > In addition, make sure the same struct is being initialized at > sf

Re: [PATCH ethtool v2] ethtool: Fix uninitialized variable use at qsfp dump

2018-10-02 Thread Andrew Lunn
On Tue, Oct 02, 2018 at 10:24:19AM +0300, Eran Ben Elisha wrote: > Struct sff_diags can be used uninitialized at sff8636_show_dom, this > caused the tool to show unreported fields (supports_alarms) by the lower > level driver. > > In addition, make sure the same struct is being initialized at > sf

[PATCH ethtool v2] ethtool: Fix uninitialized variable use at qsfp dump

2018-10-02 Thread Eran Ben Elisha
Struct sff_diags can be used uninitialized at sff8636_show_dom, this caused the tool to show unreported fields (supports_alarms) by the lower level driver. In addition, make sure the same struct is being initialized at sff8472_parse_eeprom function, to avoid the same issue here. Fixes: a5e73bb05e