Re: [PATCH iproute2] devlink: Convert conditional in dl_argv_handle_port() to switch()

2016-10-17 Thread Stephen Hemminger
On Sun, 9 Oct 2016 10:14:18 +0800 Hangbin Liu wrote: > Discovered by Phil's covscan. The final return statement is never reached. > This is not inherently clear from looking at the code, so change the > conditional to a switch() statement which should clarify this. > > CC: Phil Sutter > Signed

Re: [PATCH iproute2] devlink: Convert conditional in dl_argv_handle_port() to switch()

2016-10-09 Thread Phil Sutter
On Sun, Oct 09, 2016 at 10:14:18AM +0800, Hangbin Liu wrote: > Discovered by Phil's covscan. The final return statement is never reached. > This is not inherently clear from looking at the code, so change the > conditional to a switch() statement which should clarify this. > > CC: Phil Sutter > S

[PATCH iproute2] devlink: Convert conditional in dl_argv_handle_port() to switch()

2016-10-08 Thread Hangbin Liu
Discovered by Phil's covscan. The final return statement is never reached. This is not inherently clear from looking at the code, so change the conditional to a switch() statement which should clarify this. CC: Phil Sutter Signed-off-by: Hangbin Liu --- devlink/devlink.c | 17 -