Re: [PATCH iproute2-next] ip/tunnel: Minor cleanups

2018-02-09 Thread Serhey Popovych
David Ahern wrote: > On 2/8/18 3:57 AM, Serhey Popovych wrote: >> Few minor changes to reduce diffs between ip and ipv6 tunnel code: >> >> 1) reduce intendation by one level when adding attributes in gre and >> gre6; reorder addattr*() calls to simplify diff >> >> 2) reorder local variable

Re: [PATCH iproute2-next] ip/tunnel: Minor cleanups

2018-02-09 Thread David Ahern
On 2/8/18 3:57 AM, Serhey Popovych wrote: > Few minor changes to reduce diffs between ip and ipv6 tunnel code: > > 1) reduce intendation by one level when adding attributes in gre and > gre6; reorder addattr*() calls to simplify diff > > 2) reorder local variables definition; change thei

[PATCH iproute2-next] ip/tunnel: Minor cleanups

2018-02-08 Thread Serhey Popovych
Few minor changes to reduce diffs between ip and ipv6 tunnel code: 1) reduce intendation by one level when adding attributes in gre and gre6; reorder addattr*() calls to simplify diff 2) reorder local variables definition; change their type (e.g. for IFLA_LINK) to match ones returne