Re: [PATCH iproute2-next 0/3] ip/tunnel: Unify tunnel help message print routines

2018-02-08 Thread Serhey Popovych
David Ahern wrote: > On 2/8/18 8:35 PM, David Ahern wrote: >> On 2/8/18 3:50 AM, Serhey Popovych wrote: >>> To show only relevant diffs of ip and ipv6 variants help message print >>> routines needs to be unified and improved. >>> >>> Get rid of print_usage() and usage() wrappers: use single

Re: [PATCH iproute2-next 0/3] ip/tunnel: Unify tunnel help message print routines

2018-02-08 Thread David Ahern
On 2/8/18 8:35 PM, David Ahern wrote: > On 2/8/18 3:50 AM, Serhey Popovych wrote: >> To show only relevant diffs of ip and ipv6 variants help message print >> routines needs to be unified and improved. >> >> Get rid of print_usage() and usage() wrappers: use single function to >> output help

Re: [PATCH iproute2-next 0/3] ip/tunnel: Unify tunnel help message print routines

2018-02-08 Thread David Ahern
On 2/8/18 3:50 AM, Serhey Popovych wrote: > To show only relevant diffs of ip and ipv6 variants help message print > routines needs to be unified and improved. > > Get rid of print_usage() and usage() wrappers: use single function to > output help message. As side effect we return -1 from parse

[PATCH iproute2-next 0/3] ip/tunnel: Unify tunnel help message print routines

2018-02-08 Thread Serhey Popovych
To show only relevant diffs of ip and ipv6 variants help message print routines needs to be unified and improved. Get rid of print_usage() and usage() wrappers: use single function to output help message. As side effect we return -1 from parse function instead of calling exit(2) in case of "...