RE: [PATCH iproute2-next 2/2] vdpa: Add vdpa tool

2021-01-26 Thread Parav Pandit
> From: David Ahern > Sent: Tuesday, January 26, 2021 9:53 AM > > Looks fine. A few comments below around code re-use. > > On 1/22/21 4:26 AM, Parav Pandit wrote: > > diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c new file mode 100644 index > > ..942524b7 > > --- /dev/null > > +++ b/vdpa/vdpa.

Re: [PATCH iproute2-next 2/2] vdpa: Add vdpa tool

2021-01-25 Thread David Ahern
Looks fine. A few comments below around code re-use. On 1/22/21 4:26 AM, Parav Pandit wrote: > diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c > new file mode 100644 > index ..942524b7 > --- /dev/null > +++ b/vdpa/vdpa.c > @@ -0,0 +1,828 @@ > +// SPDX-License-Identifier: GPL-2.0+ > + > +#include >

[PATCH iproute2-next 2/2] vdpa: Add vdpa tool

2021-01-22 Thread Parav Pandit
vdpa tool is created to create, delete and query vdpa devices. examples: Show vdpa management device that supports creating, deleting vdpa devices. $ vdpa mgmtdev show vdpasim: supported_classes net $ vdpa mgmtdev show -jp { "show": { "vdpasim": { "supported_classes": [