Re: [PATCH iproute2-next 8/9] utils: Introduce and use print_name_and_link() to print name@link

2018-02-07 Thread David Ahern
On 2/7/18 12:36 AM, Serhey Popovych wrote: >> >> This patch is causing a diff on my system: >> >> # ip -br add sh > /tmp/1 >> # ip/ip -br add sh > /tmp/2 >> # diff /tmp/1 /tmp/2 >> 8c8 >> < veth-out@br3 UP fe80::18a8:89ff:fee7:55c5/64 >> --- >>> veth-out@if7 UP fe8

Re: [PATCH iproute2-next 8/9] utils: Introduce and use print_name_and_link() to print name@link

2018-02-06 Thread Serhey Popovych
David Ahern wrote: > On 2/5/18 12:49 PM, Serhey Popovych wrote: >> There is at least three places implementing same things: two in >> ipaddress.c print_linkinfo() & print_linkinfo_brief() and one in >> bridge/link.c. >> >> They are diverge from each other very little: bridge/link.c does not >> supp

Re: [PATCH iproute2-next 8/9] utils: Introduce and use print_name_and_link() to print name@link

2018-02-06 Thread David Ahern
On 2/5/18 12:49 PM, Serhey Popovych wrote: > There is at least three places implementing same things: two in > ipaddress.c print_linkinfo() & print_linkinfo_brief() and one in > bridge/link.c. > > They are diverge from each other very little: bridge/link.c does not > support JSON output at the mom

[PATCH iproute2-next 8/9] utils: Introduce and use print_name_and_link() to print name@link

2018-02-05 Thread Serhey Popovych
There is at least three places implementing same things: two in ipaddress.c print_linkinfo() & print_linkinfo_brief() and one in bridge/link.c. They are diverge from each other very little: bridge/link.c does not support JSON output at the moment and print_linkinfo_brief() does not handle IFLA_LIN