Re: [PATCH iproute2 master] bpf: unbreak libelf linkage for bpf obj loader

2017-08-11 Thread Daniel Borkmann
On 08/11/2017 01:41 AM, Stephen Hemminger wrote: On Thu, 10 Aug 2017 10:44:13 +0200 Daniel Borkmann wrote: [...] Agree. I will merge this for master, and work on better config management in net-next. Sounds good, thanks.

Re: [PATCH iproute2 master] bpf: unbreak libelf linkage for bpf obj loader

2017-08-10 Thread Stephen Hemminger
On Thu, 10 Aug 2017 10:44:13 +0200 Daniel Borkmann wrote: > On 08/10/2017 02:35 AM, Stephen Hemminger wrote: > > On Thu, 10 Aug 2017 00:15:41 +0200 > > Daniel Borkmann wrote: > > > >> Commit 69fed534a533 ("change how Config is used in Makefile's")

Re: [PATCH iproute2 master] bpf: unbreak libelf linkage for bpf obj loader

2017-08-10 Thread Daniel Borkmann
On 08/10/2017 02:35 AM, Stephen Hemminger wrote: On Thu, 10 Aug 2017 00:15:41 +0200 Daniel Borkmann wrote: Commit 69fed534a533 ("change how Config is used in Makefile's") moved HAVE_MNL specific CFLAGS/LDLIBS for building with libmnl out of the top level Makefile into

Re: [PATCH iproute2 master] bpf: unbreak libelf linkage for bpf obj loader

2017-08-09 Thread Stephen Hemminger
On Thu, 10 Aug 2017 00:15:41 +0200 Daniel Borkmann wrote: > Commit 69fed534a533 ("change how Config is used in Makefile's") moved > HAVE_MNL specific CFLAGS/LDLIBS for building with libmnl out of the > top level Makefile into sub-Makefiles. However, it also removed the >

[PATCH iproute2 master] bpf: unbreak libelf linkage for bpf obj loader

2017-08-09 Thread Daniel Borkmann
Commit 69fed534a533 ("change how Config is used in Makefile's") moved HAVE_MNL specific CFLAGS/LDLIBS for building with libmnl out of the top level Makefile into sub-Makefiles. However, it also removed the HAVE_ELF specific CFLAGS/LDLIBS entirely, which breaks the BPF object loader for tc and ip