Re: [PATCH iproute2 net 3/8] tc/pedit: Introduce 'add' operation

2017-04-24 Thread Or Gerlitz
On Mon, Apr 24, 2017 at 10:52 AM, Amir Vadai wrote: > On Sun, Apr 23, 2017 at 01:44:51PM -0400, Jamal Hadi Salim wrote: >> Thanks for the excellent work. sure, it's Amir, you know.. >> On 17-04-23 08:53 AM, Amir Vadai wrote: >> Mostly curious about hardware handling. > As to hardware handling,

Re: [PATCH iproute2 net 3/8] tc/pedit: Introduce 'add' operation

2017-04-24 Thread Amir Vadai
On Sun, Apr 23, 2017 at 01:44:51PM -0400, Jamal Hadi Salim wrote: > > Thanks for the excellent work. > > On 17-04-23 08:53 AM, Amir Vadai wrote: > > This command could be useful to increase/decrease fields value. > > > > Does this contradict the "retain" feature? Example rule to > retain the se

Re: [PATCH iproute2 net 3/8] tc/pedit: Introduce 'add' operation

2017-04-23 Thread Jamal Hadi Salim
Thanks for the excellent work. On 17-04-23 08:53 AM, Amir Vadai wrote: This command could be useful to increase/decrease fields value. Does this contradict the "retain" feature? Example rule to retain the second nibble but set the first to 0xA (essentially it X-ORs): tc filter add dev lo par

[PATCH iproute2 net 3/8] tc/pedit: Introduce 'add' operation

2017-04-23 Thread Amir Vadai
This command could be useful to increase/decrease fields value. Signed-off-by: Amir Vadai --- man/man8/tc-pedit.8 | 13 - tc/m_pedit.c| 18 +++--- 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/man/man8/tc-pedit.8 b/man/man8/tc-pedit.8 index 761d5