Re: [PATCH mlx5-next 2/4] net/mlx5: Use helper to get CQE opcode

2018-12-05 Thread Saeed Mahameed
On Tue, 2018-12-04 at 20:55 -0800, Cong Wang wrote: > On Tue, Dec 4, 2018 at 6:06 PM Saeed Mahameed > wrote: > > +static inline u8 get_cqe_opcode(struct mlx5_cqe64 *cqe) > > Make it const please. Please be specific I can do: static inline u8 get_cqe_opcode(struct mlx5_cqe64 const *cqe) if that

Re: [PATCH mlx5-next 2/4] net/mlx5: Use helper to get CQE opcode

2018-12-04 Thread Cong Wang
On Tue, Dec 4, 2018 at 6:06 PM Saeed Mahameed wrote: > > +static inline u8 get_cqe_opcode(struct mlx5_cqe64 *cqe) Make it const please.

[PATCH mlx5-next 2/4] net/mlx5: Use helper to get CQE opcode

2018-12-04 Thread Saeed Mahameed
From: Tariq Toukan Introduce and use a helper that extracts the opcode from a CQE (completion queue entry) structure. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 10 +- drivers/net/ethernet/mellanox/mlx5/core/en_t