Re: [PATCH net] Revert "mdio_bus: Remove unneeded gpiod NULL check"

2017-09-08 Thread David Miller
From: Florian Fainelli Date: Fri, 8 Sep 2017 15:38:07 -0700 > This reverts commit 95b80bf3db03c2bf572a357cf74b9a6aefef0a4a ("mdio_bus: > Remove unneeded gpiod NULL check"), this commit assumed that GPIOLIB > checks for NULL descriptors, so it's safe to drop them, but it is

Re: [PATCH net] Revert "mdio_bus: Remove unneeded gpiod NULL check"

2017-09-08 Thread Linus Walleij
On Sat, Sep 9, 2017 at 1:18 AM, Florian Fainelli wrote: > On 09/08/2017 04:13 PM, Linus Walleij wrote: >> On Sat, Sep 9, 2017 at 12:38 AM, Florian Fainelli >> wrote: >> >>> This reverts commit 95b80bf3db03c2bf572a357cf74b9a6aefef0a4a ("mdio_bus: >>>

Re: [PATCH net] Revert "mdio_bus: Remove unneeded gpiod NULL check"

2017-09-08 Thread Florian Fainelli
On 09/08/2017 04:13 PM, Linus Walleij wrote: > On Sat, Sep 9, 2017 at 12:38 AM, Florian Fainelli > wrote: > >> This reverts commit 95b80bf3db03c2bf572a357cf74b9a6aefef0a4a ("mdio_bus: >> Remove unneeded gpiod NULL check"), this commit assumed that GPIOLIB >> checks for

Re: [PATCH net] Revert "mdio_bus: Remove unneeded gpiod NULL check"

2017-09-08 Thread Linus Walleij
On Sat, Sep 9, 2017 at 12:38 AM, Florian Fainelli wrote: > This reverts commit 95b80bf3db03c2bf572a357cf74b9a6aefef0a4a ("mdio_bus: > Remove unneeded gpiod NULL check"), this commit assumed that GPIOLIB > checks for NULL descriptors, so it's safe to drop them, but it is not

[PATCH net] Revert "mdio_bus: Remove unneeded gpiod NULL check"

2017-09-08 Thread Florian Fainelli
This reverts commit 95b80bf3db03c2bf572a357cf74b9a6aefef0a4a ("mdio_bus: Remove unneeded gpiod NULL check"), this commit assumed that GPIOLIB checks for NULL descriptors, so it's safe to drop them, but it is not when CONFIG_GPIOLIB is disabled in the kernel. If we do call