Re: [PATCH net] bonding: fix bond dev flags after convert to arphrd_ether

2015-08-28 Thread Nikolay Aleksandrov
> On Aug 27, 2015, at 8:39 PM, Jay Vosburgh wrote: > > Nikolay Aleksandrov wrote: > [...] >> Restarting this thread because there’s actually a bug here, what you >> described with >> the bonding destruction is true when the slaves are all destroyed but it >> isn’t true if they’re >> just rele

Re: [PATCH net] bonding: fix bond dev flags after convert to arphrd_ether

2015-08-27 Thread Jay Vosburgh
Nikolay Aleksandrov wrote: [...] >Restarting this thread because there’s actually a bug here, what you described >with >the bonding destruction is true when the slaves are all destroyed but it isn’t >true if they’re >just released, if you take a look at bond_slave_netdev_event() the bond >destr

Re: [PATCH net] bonding: fix bond dev flags after convert to arphrd_ether

2015-08-27 Thread Nikolay Aleksandrov
> On Jul 15, 2015, at 1:32 PM, Jay Vosburgh wrote: > > Nikolay Aleksandrov wrote: > >> From: Nikolay Aleksandrov >> >> If a bonding device enslaves devices != arphrd_ether it'll change types >> and if later these devices are released, it can enslave an arphrd_ether >> device and switch back

Re: [PATCH net] bonding: fix bond dev flags after convert to arphrd_ether

2015-07-20 Thread David Miller
From: Nikolay Aleksandrov Date: Wed, 15 Jul 2015 22:55:55 +0200 > Dave please ignore this patch, I'll send a better fix. OK -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/ma

Re: [PATCH net] bonding: fix bond dev flags after convert to arphrd_ether

2015-07-15 Thread Nikolay Aleksandrov
On 07/15/2015 10:09 PM, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > If a bonding device enslaves devices != arphrd_ether it'll change types > and if later these devices are released, it can enslave an arphrd_ether > device and switch back calling ether_setup() which resets dev->fla

Re: [PATCH net] bonding: fix bond dev flags after convert to arphrd_ether

2015-07-15 Thread Nikolay Aleksandrov
On 07/15/2015 10:32 PM, Jay Vosburgh wrote: > Nikolay Aleksandrov wrote: > >> From: Nikolay Aleksandrov >> >> If a bonding device enslaves devices != arphrd_ether it'll change types >> and if later these devices are released, it can enslave an arphrd_ether >> device and switch back calling ether

Re: [PATCH net] bonding: fix bond dev flags after convert to arphrd_ether

2015-07-15 Thread Jay Vosburgh
Nikolay Aleksandrov wrote: >From: Nikolay Aleksandrov > >If a bonding device enslaves devices != arphrd_ether it'll change types >and if later these devices are released, it can enslave an arphrd_ether >device and switch back calling ether_setup() which resets dev->flags to >IFF_BROADCAST|IFF_MU

[PATCH net] bonding: fix bond dev flags after convert to arphrd_ether

2015-07-15 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov If a bonding device enslaves devices != arphrd_ether it'll change types and if later these devices are released, it can enslave an arphrd_ether device and switch back calling ether_setup() which resets dev->flags to IFF_BROADCAST|IFF_MULTICAST and clears IFF_MASTER which