Re: [PATCH net] cls_flower: Fix incorrect idr release when failing to modify rule

2018-05-31 Thread David Miller
From: Paul Blakey Date: Wed, 30 May 2018 11:29:15 +0300 > When we fail to modify a rule, we incorrectly release the idr handle > of the unmodified old rule. > > Fix that by checking if we need to release it. > > Fixes: fe2502e49b58 ("net_sched: remove cls_flower idr on failure") > Reported-by:

[PATCH net] cls_flower: Fix incorrect idr release when failing to modify rule

2018-05-30 Thread Paul Blakey
When we fail to modify a rule, we incorrectly release the idr handle of the unmodified old rule. Fix that by checking if we need to release it. Fixes: fe2502e49b58 ("net_sched: remove cls_flower idr on failure") Reported-by: Vlad Buslov Reviewed-by: Roi Dayan Acked-by: Jiri Pirko Signed-off-by