Re: [PATCH net] ipv6: do not leave garbage in rt->fib6_metrics

2018-10-05 Thread Eric Dumazet
On Fri, Oct 5, 2018 at 11:57 AM David Miller wrote: > Applied to net-next, thanks Eric. > > Subject should have said net-next instead of net btw. Oops, sorry for that, I used the wrong script. Thanks.

Re: [PATCH net] ipv6: do not leave garbage in rt->fib6_metrics

2018-10-05 Thread David Miller
From: Eric Dumazet Date: Fri, 5 Oct 2018 09:17:50 -0700 > In case ip_fib_metrics_init() returns an error, we better > rewrite rt->fib6_metrics with _default_metrics so that > we do not crash later in ip_fib_metrics_put() > > Fixes: 767a2217533f ("net: common metrics init helper for FIB

Re: [PATCH net] ipv6: do not leave garbage in rt->fib6_metrics

2018-10-05 Thread Eric Dumazet
On Fri, Oct 5, 2018 at 9:29 AM David Ahern wrote: > > On 10/5/18 10:17 AM, Eric Dumazet wrote: > > In case ip_fib_metrics_init() returns an error, we better > > rewrite rt->fib6_metrics with _default_metrics so that > > we do not crash later in ip_fib_metrics_put() > > > > Fixes: 767a2217533f

Re: [PATCH net] ipv6: do not leave garbage in rt->fib6_metrics

2018-10-05 Thread David Ahern
On 10/5/18 10:17 AM, Eric Dumazet wrote: > In case ip_fib_metrics_init() returns an error, we better > rewrite rt->fib6_metrics with _default_metrics so that > we do not crash later in ip_fib_metrics_put() > > Fixes: 767a2217533f ("net: common metrics init helper for FIB entries") >

[PATCH net] ipv6: do not leave garbage in rt->fib6_metrics

2018-10-05 Thread Eric Dumazet
In case ip_fib_metrics_init() returns an error, we better rewrite rt->fib6_metrics with _default_metrics so that we do not crash later in ip_fib_metrics_put() Fixes: 767a2217533f ("net: common metrics init helper for FIB entries") Signed-off-by: Eric Dumazet Reported-by: syzbot ---