Re: [PATCH net] ipv6: don't get lwtstate twice in ip6_rt_copy_init()

2018-09-01 Thread David Miller
From: Alexey Kodanev Date: Thu, 30 Aug 2018 19:11:24 +0300 > Commit 80f1a0f4e0cd ("net/ipv6: Put lwtstate when destroying fib6_info") > partially fixed the kmemleak [1], lwtstate can be copied from fib6_info, > with ip6_rt_copy_init(), and it should be done only once there. > > rt->dst.lwtstate

Re: [PATCH net] ipv6: don't get lwtstate twice in ip6_rt_copy_init()

2018-08-31 Thread Alexey Kodanev
On 30.08.2018 19:10, David Ahern wrote: > On 8/30/18 10:11 AM, Alexey Kodanev wrote: ... >> unreferenced object 0x880b6aaa14e0 (size 64): >> comm "ip", pid 10577, jiffies 4295149341 (age 1273.903s) >> hex dump (first 32 bytes): >> 01 00 04 00 04 00 00 00 10 00 00 00 00 00 00 00

Re: [PATCH net] ipv6: don't get lwtstate twice in ip6_rt_copy_init()

2018-08-30 Thread David Ahern
On 8/30/18 10:11 AM, Alexey Kodanev wrote: > Commit 80f1a0f4e0cd ("net/ipv6: Put lwtstate when destroying fib6_info") > partially fixed the kmemleak [1], lwtstate can be copied from fib6_info, > with ip6_rt_copy_init(), and it should be done only once there. > > rt->dst.lwtstate is set by

[PATCH net] ipv6: don't get lwtstate twice in ip6_rt_copy_init()

2018-08-30 Thread Alexey Kodanev
Commit 80f1a0f4e0cd ("net/ipv6: Put lwtstate when destroying fib6_info") partially fixed the kmemleak [1], lwtstate can be copied from fib6_info, with ip6_rt_copy_init(), and it should be done only once there. rt->dst.lwtstate is set by ip6_rt_init_dst(), at the start of the function