Re: [PATCH net] ipv6: kill sk_dst_lock

2015-12-02 Thread Eric Dumazet
On Wed, 2015-12-02 at 23:42 -0500, David Miller wrote: > Please update the commit log message with the details you > provided in a reply to this thread. Sure, I sent a v2. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH net] ipv6: kill sk_dst_lock

2015-12-02 Thread David Miller
From: Eric Dumazet Date: Mon, 30 Nov 2015 08:35:15 -0800 > From: Eric Dumazet > > While testing the np->opt RCU conversion, I found that UDP/IPv6 was > using a mixture of xchg() and sk_dst_lock to protect concurrent changes > to sk->sk_dst_cache,

[PATCH net] ipv6: kill sk_dst_lock

2015-11-30 Thread Eric Dumazet
From: Eric Dumazet While testing the np->opt RCU conversion, I found that UDP/IPv6 was using a mixture of xchg() and sk_dst_lock to protect concurrent changes to sk->sk_dst_cache, leading to possible corruptions and crashes. ip6_sk_dst_lookup_flow() uses sk_dst_check()

Re: [PATCH net] ipv6: kill sk_dst_lock

2015-11-30 Thread Paolo Abeni
On Mon, 2015-11-30 at 08:35 -0800, Eric Dumazet wrote: > ip6_sk_dst_lookup_flow() uses sk_dst_check() anyway, so the simplest > way to fix the mess is to remove sk_dst_lock completely, as we did for > IPv4. Probably I'm missing something here, but why we don't need to sync the update of

Re: [PATCH net] ipv6: kill sk_dst_lock

2015-11-30 Thread Eric Dumazet
On Mon, 2015-11-30 at 19:13 +0100, Paolo Abeni wrote: > On Mon, 2015-11-30 at 08:35 -0800, Eric Dumazet wrote: > > ip6_sk_dst_lookup_flow() uses sk_dst_check() anyway, so the simplest > > way to fix the mess is to remove sk_dst_lock completely, as we did for > > IPv4. > > Probably I'm missing

Re: [PATCH net] ipv6: kill sk_dst_lock

2015-11-30 Thread YOSHIFUJI Hideaki
Hi, Eric Dumazet wrote: > diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h > index 2bfb2ad2fab1..877f682989b8 100644 > --- a/include/net/ip6_route.h > +++ b/include/net/ip6_route.h > @@ -133,27 +133,18 @@ void rt6_clean_tohost(struct net *net, struct in6_addr > *gateway); > /* >

Re: [PATCH net] ipv6: kill sk_dst_lock

2015-11-30 Thread Eric Dumazet
On Tue, 2015-12-01 at 10:44 +0900, YOSHIFUJI Hideaki wrote: > Hi, > > Eric Dumazet wrote: > > diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h > > index 2bfb2ad2fab1..877f682989b8 100644 > > --- a/include/net/ip6_route.h > > +++ b/include/net/ip6_route.h > > @@ -133,27 +133,18 @@