Re: [PATCH net] ixgbe: napi_poll must return the work done

2016-06-16 Thread Keller, Jacob E
On Wed, 2016-06-15 at 09:34 -0700, Venkatesh Srinivas wrote: > Reviewed-by: Venkatesh Srinivas > > The same bit of code appears in fm10k and i40e/i40evf. ixgb appears > to > correctly return work_done. > > ixgbe_poll also appears to return an (minor) incorrect work_done

Re: [PATCH net] ixgbe: napi_poll must return the work done

2016-06-16 Thread Keller, Jacob E
On Wed, 2016-06-15 at 09:34 -0700, Venkatesh Srinivas wrote: > On Wed, Jun 15, 2016 at 6:37 AM, Paolo Abeni > wrote: > > > > Currently the function ixgbe_poll() returns 0 when it clean > > completely > > the rx rings, but this foul budget accounting in core code. > > Fix this

Re: [PATCH net] ixgbe: napi_poll must return the work done

2016-06-16 Thread Keller, Jacob E
On Wed, 2016-06-15 at 09:34 -0700, Venkatesh Srinivas wrote: > On Wed, Jun 15, 2016 at 6:37 AM, Paolo Abeni > wrote: > > > > Currently the function ixgbe_poll() returns 0 when it clean > > completely > > the rx rings, but this foul budget accounting in core code. > > Fix this

Re: [PATCH net] ixgbe: napi_poll must return the work done

2016-06-15 Thread Venkatesh Srinivas
On Wed, Jun 15, 2016 at 6:37 AM, Paolo Abeni wrote: > Currently the function ixgbe_poll() returns 0 when it clean completely > the rx rings, but this foul budget accounting in core code. > Fix this returning the actual work done, capped to weight - 1, since > the core doesn't

Re: [PATCH net] ixgbe: napi_poll must return the work done

2016-06-15 Thread Paolo Abeni
On Wed, 2016-06-15 at 08:20 -0700, Alexander Duyck wrote: > On Wed, Jun 15, 2016 at 6:37 AM, Paolo Abeni wrote: > > Currently the function ixgbe_poll() returns 0 when it clean completely > > the rx rings, but this foul budget accounting in core code. > > Fix this returning the

Re: [PATCH net] ixgbe: napi_poll must return the work done

2016-06-15 Thread Alexander Duyck
On Wed, Jun 15, 2016 at 6:37 AM, Paolo Abeni wrote: > Currently the function ixgbe_poll() returns 0 when it clean completely > the rx rings, but this foul budget accounting in core code. > Fix this returning the actual work done, capped to weight - 1, since > the core doesn't

[PATCH net] ixgbe: napi_poll must return the work done

2016-06-15 Thread Paolo Abeni
Currently the function ixgbe_poll() returns 0 when it clean completely the rx rings, but this foul budget accounting in core code. Fix this returning the actual work done, capped to weight - 1, since the core doesn't allow to return the full budget when the driver modifies the napi status