On 1/17/17 1:54 PM, David Miller wrote:
> From: David Ahern
> Date: Tue, 17 Jan 2017 13:46:22 -0700
>
>> In short seems like removing the dev + the current patch dropping
>> the lock fixes the current deadlock problem and should be fine.
>
> What about the state recorded by fib_get_nhs() and sim
From: David Ahern
Date: Tue, 17 Jan 2017 13:46:22 -0700
> In short seems like removing the dev + the current patch dropping
> the lock fixes the current deadlock problem and should be fine.
What about the state recorded by fib_get_nhs() and similar? There is
a mapping from ifindex to ->nh_dev w
On 1/17/17 1:38 PM, David Miller wrote:
> But, that being said, I don't think we can legitimately just remove the
> autoload functionality. It's been there for close to a full year and
> I guarantee people will get burned if we take it away.
>
> We have to find a way to fix this.
I have patch th
From: David Ahern
Date: Tue, 17 Jan 2017 11:04:35 -0700
> handling restart for all code paths seems a bit risky for
> 4.10. Perhaps then the best course for 4.10 and older stable
> releases is to remove the autoload code from lwtunnel. It can be
> re-added once the recovery path is handled.
Inde
On 1/17/17 10:26 AM, Robert Shearman wrote:
> Ok, I'll continue looking too and let you know if there's anything else that
> pops up.
>
> Having said that, even if we eliminate all the unreferenced objects in the
> current code, what are the chances that we'll be able to keep it this way
> goin
On 17/01/17 17:07, David Ahern wrote:
On 1/17/17 3:04 AM, Robert Shearman wrote:
Is it safe to release the rtnl lock here? E.g. neither fib_get_nhs nor
fib_create_info take a reference on the device and further up inet_rtm_newroute
has a pointer to the struct fib_table without taking a referen
On 1/17/17 3:04 AM, Robert Shearman wrote:
> Is it safe to release the rtnl lock here? E.g. neither fib_get_nhs nor
> fib_create_info take a reference on the device and further up
> inet_rtm_newroute has a pointer to the struct fib_table without taking a
> reference.
fib tables can not be delet
On 17/01/17 05:33, David Ahern wrote:
Trying to add an mpls encap route when the MPLS modules are not loaded
hangs. For example:
CONFIG_MPLS=y
CONFIG_NET_MPLS_GSO=m
CONFIG_MPLS_ROUTING=m
CONFIG_MPLS_IPTUNNEL=m
$ ip route add 10.10.10.10/32 encap mpls 100 via inet 10.100.1.2
Trying to add an mpls encap route when the MPLS modules are not loaded
hangs. For example:
CONFIG_MPLS=y
CONFIG_NET_MPLS_GSO=m
CONFIG_MPLS_ROUTING=m
CONFIG_MPLS_IPTUNNEL=m
$ ip route add 10.10.10.10/32 encap mpls 100 via inet 10.100.1.2
The ip command hangs:
root 880
