Re: [PATCH net] macvlan: remove duplicate check

2018-12-06 Thread Matteo Croce
On Wed, Dec 5, 2018 at 8:40 PM David Miller wrote: > > From: Matteo Croce > Date: Tue, 4 Dec 2018 18:05:42 +0100 > > > Following commit 59f997b088d2 ("macvlan: return correct error value"), > > there is a duplicate check for mac addresses both in macvlan_sync_address() > > and

Re: [PATCH net] macvlan: remove duplicate check

2018-12-05 Thread David Miller
From: Matteo Croce Date: Tue, 4 Dec 2018 18:05:42 +0100 > Following commit 59f997b088d2 ("macvlan: return correct error value"), > there is a duplicate check for mac addresses both in macvlan_sync_address() > and macvlan_set_mac_address(). > As the former calls the latter, remove the one in

[PATCH net] macvlan: remove duplicate check

2018-12-04 Thread Matteo Croce
Following commit 59f997b088d2 ("macvlan: return correct error value"), there is a duplicate check for mac addresses both in macvlan_sync_address() and macvlan_set_mac_address(). As the former calls the latter, remove the one in macvlan_set_mac_address() and move the one in macvlan_sync_address()