Re: [PATCH net] net/sched: act_gate: Unlock ->tcfa_lock in tc_setup_flow_action()

2020-10-21 Thread Guillaume Nault
On Tue, Oct 20, 2020 at 05:37:22PM -0700, Cong Wang wrote: > On Tue, Oct 20, 2020 at 8:34 AM Guillaume Nault wrote: > > > > We need to jump to the "err_out_locked" label when > > tcf_gate_get_entries() fails. Otherwise, tc_setup_flow_action() exits > > with ->tcfa_lock still held. > > > > Fixes: d

Re: [PATCH net] net/sched: act_gate: Unlock ->tcfa_lock in tc_setup_flow_action()

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 17:37:22 -0700 Cong Wang wrote: > On Tue, Oct 20, 2020 at 8:34 AM Guillaume Nault wrote: > > > > We need to jump to the "err_out_locked" label when > > tcf_gate_get_entries() fails. Otherwise, tc_setup_flow_action() exits > > with ->tcfa_lock still held. > > > > Fixes: d29bdd69

Re: [PATCH net] net/sched: act_gate: Unlock ->tcfa_lock in tc_setup_flow_action()

2020-10-20 Thread Cong Wang
On Tue, Oct 20, 2020 at 8:34 AM Guillaume Nault wrote: > > We need to jump to the "err_out_locked" label when > tcf_gate_get_entries() fails. Otherwise, tc_setup_flow_action() exits > with ->tcfa_lock still held. > > Fixes: d29bdd69ecdd ("net: schedule: add action gate offloading") > Signed-off-by

[PATCH net] net/sched: act_gate: Unlock ->tcfa_lock in tc_setup_flow_action()

2020-10-20 Thread Guillaume Nault
We need to jump to the "err_out_locked" label when tcf_gate_get_entries() fails. Otherwise, tc_setup_flow_action() exits with ->tcfa_lock still held. Fixes: d29bdd69ecdd ("net: schedule: add action gate offloading") Signed-off-by: Guillaume Nault --- net/sched/cls_api.c | 2 +- 1 file changed, 1