Re: [PATCH net] net/sched: act_police: add missing spinlock initialization

2018-11-23 Thread David Miller
From: Davide Caratti Date: Wed, 21 Nov 2018 18:23:53 +0100 > commit f2cbd4852820 ("net/sched: act_police: fix race condition on state > variables") introduces a new spinlock, but forgets its initialization. > Ensure that tcf_police_init() initializes 'tcfp_lock' every time a 'police' > action is

Re: [PATCH net] net/sched: act_police: add missing spinlock initialization

2018-11-21 Thread Jiri Pirko
Wed, Nov 21, 2018 at 06:23:53PM CET, dcara...@redhat.com wrote: >commit f2cbd4852820 ("net/sched: act_police: fix race condition on state >variables") introduces a new spinlock, but forgets its initialization. >Ensure that tcf_police_init() initializes 'tcfp_lock' every time a 'police' >action is

Re: [PATCH net] net/sched: act_police: add missing spinlock initialization

2018-11-21 Thread Cong Wang
On Wed, Nov 21, 2018 at 9:24 AM Davide Caratti wrote: > > commit f2cbd4852820 ("net/sched: act_police: fix race condition on state > variables") introduces a new spinlock, but forgets its initialization. > Ensure that tcf_police_init() initializes 'tcfp_lock' every time a 'police' > action is

[PATCH net] net/sched: act_police: add missing spinlock initialization

2018-11-21 Thread Davide Caratti
commit f2cbd4852820 ("net/sched: act_police: fix race condition on state variables") introduces a new spinlock, but forgets its initialization. Ensure that tcf_police_init() initializes 'tcfp_lock' every time a 'police' action is newly created, to avoid the following lockdep splat: INFO: trying