Re: [PATCH net] net/sched: fix memory leak in act_tunnel_key_init()

2018-09-05 Thread David Miller
From: Davide Caratti Date: Tue, 4 Sep 2018 19:00:19 +0200 > If users try to install act_tunnel_key 'set' rules with duplicate values > of 'index', the tunnel metadata are allocated, but never released. Then, > kmemleak complains as follows: ... > This problem theoretically happens also in case

Re: [PATCH net] net/sched: fix memory leak in act_tunnel_key_init()

2018-09-04 Thread Cong Wang
On Tue, Sep 4, 2018 at 10:00 AM Davide Caratti wrote: > > If users try to install act_tunnel_key 'set' rules with duplicate values > of 'index', the tunnel metadata are allocated, but never released. Then, > kmemleak complains as follows: Acked-by: Cong Wang

[PATCH net] net/sched: fix memory leak in act_tunnel_key_init()

2018-09-04 Thread Davide Caratti
If users try to install act_tunnel_key 'set' rules with duplicate values of 'index', the tunnel metadata are allocated, but never released. Then, kmemleak complains as follows: # tc a a a tunnel_key set src_ip 1.1.1.1 dst_ip 2.2.2.2 id 42 index 111 # echo clear > /sys/kernel/debug/kmemleak # tc