[PATCH net] net: br: Fix igmp snooping offload with CONFIG_BRIDGE_VLAN_FILTERING

2017-10-02 Thread Andrew Lunn
With CONFIG_BRIDGE_VLAN_FILTERING enabled, but the feature not enabled via /sys/class/net/brX/bridge/vlan_filtering, mdb offloaded to the kernel have the wrong VID. When an interface is added to the bridge, switchdev is first used to notify the hardware that a port has joined a bridge. This is imm

Re: [PATCH net] net: br: Fix igmp snooping offload with CONFIG_BRIDGE_VLAN_FILTERING

2017-10-02 Thread Toshiaki Makita
On 2017/10/03 9:55, Andrew Lunn wrote: > With CONFIG_BRIDGE_VLAN_FILTERING enabled, but the feature not enabled > via /sys/class/net/brX/bridge/vlan_filtering, mdb offloaded to the > kernel have the wrong VID. > > When an interface is added to the bridge, switchdev is first used to > notify the ha

Re: [PATCH net] net: br: Fix igmp snooping offload with CONFIG_BRIDGE_VLAN_FILTERING

2017-10-03 Thread Andrew Lunn
On Tue, Oct 03, 2017 at 12:29:56PM +0900, Toshiaki Makita wrote: > On 2017/10/03 9:55, Andrew Lunn wrote: > > With CONFIG_BRIDGE_VLAN_FILTERING enabled, but the feature not enabled > > via /sys/class/net/brX/bridge/vlan_filtering, mdb offloaded to the > > kernel have the wrong VID. > > > > When an

Re: [PATCH net] net: br: Fix igmp snooping offload with CONFIG_BRIDGE_VLAN_FILTERING

2017-10-03 Thread Vivien Didelot
Andrew Lunn writes: > Now, i just noticed the switchdev call above. I don't think the DSA > layer implements SWITCHDEV_ATTR_ID_BRIDGE_VLAN_FILTERING. It probably > should. So what is it supposed to do with this VLAN when filtering is > disabled? The DSA layer does implement SWITCHDEV_ATTR_ID_BRI

Re: [PATCH net] net: br: Fix igmp snooping offload with CONFIG_BRIDGE_VLAN_FILTERING

2017-10-03 Thread Toshiaki Makita
On 17/10/03 (火) 21:16, Andrew Lunn wrote: On Tue, Oct 03, 2017 at 12:29:56PM +0900, Toshiaki Makita wrote: On 2017/10/03 9:55, Andrew Lunn wrote: With CONFIG_BRIDGE_VLAN_FILTERING enabled, but the feature not enabled via /sys/class/net/brX/bridge/vlan_filtering, mdb offloaded to the kernel have

Re: [PATCH net] net: br: Fix igmp snooping offload with CONFIG_BRIDGE_VLAN_FILTERING

2017-10-03 Thread Andrew Lunn
> The vlan will be effective only when vlan_filtering is enabled. > When vlan_filtering is disabled, vlan information is still kept in the > bridge and gets effective later when vlan_filtering becomes enable. O.K, so things are starting to get clearer. So when vlan filtering is disabled, the hard

Re: [PATCH net] net: br: Fix igmp snooping offload with CONFIG_BRIDGE_VLAN_FILTERING

2017-10-03 Thread Vivien Didelot
Andrew Lunn writes: >> The vlan will be effective only when vlan_filtering is enabled. >> When vlan_filtering is disabled, vlan information is still kept in the >> bridge and gets effective later when vlan_filtering becomes enable. > > O.K, so things are starting to get clearer. > > So when vlan

Re: [PATCH net] net: br: Fix igmp snooping offload with CONFIG_BRIDGE_VLAN_FILTERING

2017-10-03 Thread Ido Schimmel
On Tue, Oct 03, 2017 at 12:25:08PM -0400, Vivien Didelot wrote: > Andrew Lunn writes: > > >> The vlan will be effective only when vlan_filtering is enabled. > >> When vlan_filtering is disabled, vlan information is still kept in the > >> bridge and gets effective later when vlan_filtering becomes

Re: [PATCH net] net: br: Fix igmp snooping offload with CONFIG_BRIDGE_VLAN_FILTERING

2017-10-03 Thread Toshiaki Makita
On 2017/10/04 1:42, Ido Schimmel wrote: > On Tue, Oct 03, 2017 at 12:25:08PM -0400, Vivien Didelot wrote: >> Andrew Lunn writes: >> The vlan will be effective only when vlan_filtering is enabled. When vlan_filtering is disabled, vlan information is still kept in the bridge and gets

Re: [PATCH net] net: br: Fix igmp snooping offload with CONFIG_BRIDGE_VLAN_FILTERING

2017-10-04 Thread Ido Schimmel
On Wed, Oct 04, 2017 at 01:52:20PM +0900, Toshiaki Makita wrote: > On 2017/10/04 1:42, Ido Schimmel wrote: > > The driver can make sure it's able to handle the configured > > `vlan_filtering` state during port enslavement to the bridge and also > > forbid it from being toggled once it's enslaved. >