Re: [PATCH net] net: dsa: fix preparation of a port STP update

2015-09-29 Thread David Miller
From: Vivien Didelot Date: Tue, 29 Sep 2015 14:17:54 -0400 > Because of the default 0 value of ret in dsa_slave_port_attr_set, a > driver may return -EOPNOTSUPP from the commit phase of a STP state, > which triggers a WARN() from switchdev. > > This happened

[PATCH net] net: dsa: fix preparation of a port STP update

2015-09-29 Thread Vivien Didelot
Because of the default 0 value of ret in dsa_slave_port_attr_set, a driver may return -EOPNOTSUPP from the commit phase of a STP state, which triggers a WARN() from switchdev. This happened on a 6185 switch which does not support hardware bridging. Fixes: 3563606258cf ("switchdev: convert STP