Re: [PATCH net] net: phy: don't allow __set_phy_supported to add unsupported modes

2018-12-03 Thread David Miller
From: Heiner Kallweit Date: Mon, 3 Dec 2018 08:19:33 +0100 > Currently __set_phy_supported allows to add modes w/o checking whether > the PHY supports them. This is wrong, it should never add modes but > only remove modes we don't want to support. > > The commit marked as fixed didn't do

Re: [PATCH net] net: phy: don't allow __set_phy_supported to add unsupported modes

2018-12-03 Thread Andrew Lunn
On Mon, Dec 03, 2018 at 08:19:33AM +0100, Heiner Kallweit wrote: > Currently __set_phy_supported allows to add modes w/o checking whether > the PHY supports them. This is wrong, it should never add modes but > only remove modes we don't want to support. > > The commit marked as fixed didn't do

[PATCH net] net: phy: don't allow __set_phy_supported to add unsupported modes

2018-12-02 Thread Heiner Kallweit
Currently __set_phy_supported allows to add modes w/o checking whether the PHY supports them. This is wrong, it should never add modes but only remove modes we don't want to support. The commit marked as fixed didn't do anything wrong, it just copied existing functionality to the helper which is