Re: [PATCH net] net: skbuff: Fix incorrect skb->mac_len adjustment in skb_vlan_push()

2016-09-28 Thread Shmulik Ladkani
Hi, On Tue, 27 Sep 2016 13:04:35 -0700, pshe...@ovn.org wrote: > > OVS MPLS does depends on mac-len to track MPLS header (ref > skb_mpls_header()). Therefore vlan header changes needs to update > mac-len. Thanks for the explanation. I'm working on a better fix. Regards, Shmulik

Re: [PATCH net] net: skbuff: Fix incorrect skb->mac_len adjustment in skb_vlan_push()

2016-09-27 Thread pravin shelar
On Tue, Sep 27, 2016 at 10:31 AM, Shmulik Ladkani wrote: > In case 'skb_vlan_push' is called on an skb with a hw-accel vlan tag > already present, the existing hw-accel tag is inserted into payload, and > the new given tag is placed as new hw-accel tag. > > After the insertion: > - 'mac_header' i

[PATCH net] net: skbuff: Fix incorrect skb->mac_len adjustment in skb_vlan_push()

2016-09-27 Thread Shmulik Ladkani
In case 'skb_vlan_push' is called on an skb with a hw-accel vlan tag already present, the existing hw-accel tag is inserted into payload, and the new given tag is placed as new hw-accel tag. After the insertion: - 'mac_header' is adjusted to point to the new start of the vlan_ethhdr - 'data' is