Re: [PATCH net] r8169: fix setting driver_data after register_netdev

2018-03-26 Thread Andrew Lunn
On Tue, Mar 27, 2018 at 12:18:40AM +0200, Francois Romieu wrote: > Andrew Lunn : > [...] > > How about rtl8169_get_wol() and rtl8169_set_wol(). And > > rtl8169_get_ethtool_stats(). > > rtl8169_get_wol does not depend on dev->driver_data. Neither does > rtl8169_set_wol() nor

Re: [PATCH net] r8169: fix setting driver_data after register_netdev

2018-03-26 Thread Francois Romieu
Andrew Lunn : [...] > How about rtl8169_get_wol() and rtl8169_set_wol(). And > rtl8169_get_ethtool_stats(). rtl8169_get_wol does not depend on dev->driver_data. Neither does rtl8169_set_wol() nor rtl8169_get_ethtool_stats(). > Basically anything which makes use of run time power

Re: [PATCH net] r8169: fix setting driver_data after register_netdev

2018-03-26 Thread David Miller
From: Heiner Kallweit Date: Mon, 26 Mar 2018 00:32:42 +0200 > pci_set_drvdata() is called only after registering the net_device, > therefore we could run into a NPE if one of the functions using > driver_data is called before it's set. > > Fix this by calling

Re: [PATCH net] r8169: fix setting driver_data after register_netdev

2018-03-25 Thread Andrew Lunn
On Mon, Mar 26, 2018 at 01:07:00AM +0200, Francois Romieu wrote: > Heiner Kallweit : > > pci_set_drvdata() is called only after registering the net_device, > > therefore we could run into a NPE if one of the functions using > > driver_data is called before it's set. > > > >

Re: [PATCH net] r8169: fix setting driver_data after register_netdev

2018-03-25 Thread Francois Romieu
Heiner Kallweit : > pci_set_drvdata() is called only after registering the net_device, > therefore we could run into a NPE if one of the functions using > driver_data is called before it's set. > > Fix this by calling pci_set_drvdata() before registering the > net_device. >

[PATCH net] r8169: fix setting driver_data after register_netdev

2018-03-25 Thread Heiner Kallweit
pci_set_drvdata() is called only after registering the net_device, therefore we could run into a NPE if one of the functions using driver_data is called before it's set. Fix this by calling pci_set_drvdata() before registering the net_device. This fix is a candidate for stable. As far as I can